Sign upLogin

gadael/gadael

View on GitHub
Star
api/Request.api.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function createRandomAbsence has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

api.createRandomAbsence = function(app, user, dtstart, dtend, nbdays, timeCreated) {

    function createOnRight(rightDocument) {
        return rightDocument.getPeriodRenewal(dtstart, dtend)
Severity: Minor
Found in api/Request.api.js - About 1 hr to fix

    Function createRandomAbsence has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    api.createRandomAbsence = function(app, user, dtstart, dtend, nbdays, timeCreated) {

    function createOnRight(rightDocument) {
        return rightDocument.getPeriodRenewal(dtstart, dtend)
    Severity: Minor
    Found in api/Request.api.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function createOnRenewal has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function createOnRenewal(app, rightDocument, renewal, user, dtstart, dtend, nbdays, timeCreated) {
    Severity: Major
    Found in api/Request.api.js - About 1 hr to fix

      Function createRandomAbsence has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      api.createRandomAbsence = function(app, user, dtstart, dtend, nbdays, timeCreated) {
      Severity: Minor
      Found in api/Request.api.js - About 45 mins to fix

        Function createAbsenceOnRenewal has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        api.createAbsenceOnRenewal = function(app, renewal, user, dtstart, dtend, nbdays) {
        Severity: Minor
        Found in api/Request.api.js - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status