Sign upLogin

gadael/gadael

View on GitHub
Star
api/User.api.js

Summary

Maintainability
C
1 day
Test Coverage

Function createRandomAccountRequest has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

api.createRandomAccountRequest = function(app, collectionProps, rightProps, dtstart, dtend, nbdays) {
Severity: Minor
Found in api/User.api.js - About 45 mins to fix

    Function createRandomAdmin has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    api.createRandomAdmin = function(app, email, password, lastname, firstname) {
    Severity: Minor
    Found in api/User.api.js - About 35 mins to fix

      Function createRandomAccount has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      api.createRandomAccount = function(app, email, password, lastname, firstname) {
      Severity: Minor
      Found in api/User.api.js - About 35 mins to fix

        Function createEncUser has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        api.createEncUser = function(app, email, password, lastname, firstname) {
        Severity: Minor
        Found in api/User.api.js - About 35 mins to fix

          Function createRandomUser has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          api.createRandomUser = function(app, email, password, lastname, firstname) {
          Severity: Minor
          Found in api/User.api.js - About 35 mins to fix

            Function createRandomManager has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            api.createRandomManager = function(app, email, password, lastname, firstname) {
            Severity: Minor
            Found in api/User.api.js - About 35 mins to fix

              Function createProportionConsRequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              api.createProportionConsRequest = function(app, attendance, dtstart, dtend, nbdays) {
              Severity: Minor
              Found in api/User.api.js - About 35 mins to fix

                Function createBusinessDaysConsRequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                api.createBusinessDaysConsRequest = function(app, dtstart, dtend, nbdays, availableQuantity) {
                Severity: Minor
                Found in api/User.api.js - About 35 mins to fix

                  Function createEncAdmin has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  api.createEncAdmin = function(app, email, password, lastname, firstname) {
                  Severity: Minor
                  Found in api/User.api.js - About 35 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    function linkFrenchDefaultScheduleCalendar(app, account) {
    let scheduleCalendar = new app.db.models.AccountScheduleCalendar();
    scheduleCalendar.account = account._id;
    scheduleCalendar.calendar = '5740adf51cf1a569643cc101'; // 40H full time work schedule
    scheduleCalendar.from = new Date(2000,0,1,0,0,0,0);
                    Severity: Major
                    Found in api/User.api.js and 1 other location - About 2 hrs to fix
                    api/User.api.js on lines 25..31

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 87.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    function linkFrenchDefaultNWDaysCalendar(app, account) {
    let nonworkingdaysCalendar = new app.db.models.AccountNWDaysCalendar();
    nonworkingdaysCalendar.account = account._id;
    nonworkingdaysCalendar.calendar = '5740adf51cf1a569643cc100'; // france metropolis
    nonworkingdaysCalendar.from = new Date(2000,0,1,0,0,0,0);
                    Severity: Major
                    Found in api/User.api.js and 1 other location - About 2 hrs to fix
                    api/User.api.js on lines 17..23

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 87.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status