Sign upLogin

gadael/gadael

View on GitHub
Star
api/services/admin/beneficiaries/save.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function saveBeneficiary has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function saveBeneficiary(service, params) {

    const gt = service.app.utility.gettext;
    const Beneficiary = service.app.db.models.Beneficiary;
    const Right = service.app.db.models.Right;
Severity: Major
Found in api/services/admin/beneficiaries/save.js - About 2 hrs to fix

    Function saveBeneficiary has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function saveBeneficiary(service, params) {

    const gt = service.app.utility.gettext;
    const Beneficiary = service.app.db.models.Beneficiary;
    const Right = service.app.db.models.Right;
    Severity: Minor
    Found in api/services/admin/beneficiaries/save.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 20 locations. Consider refactoring.
    Open

    exports = module.exports = function(services, app) {

    var service = new services.save(app);

    /**
    Severity: Major
    Found in api/services/admin/beneficiaries/save.js and 19 other locations - About 2 hrs to fix
    api/services/admin/accountcollections/save.js on lines 165..183
    api/services/admin/accountnwdayscalendars/save.js on lines 156..174
    api/services/admin/accountschedulecalendars/save.js on lines 154..172
    api/services/admin/calendars/save.js on lines 114..132
    api/services/admin/compulsoryleaves/save.js on lines 642..667
    api/services/admin/departments/save.js on lines 100..118
    api/services/admin/invitations/save.js on lines 125..143
    api/services/admin/lunchs/save.js on lines 57..73
    api/services/admin/overtimesummary/save.js on lines 168..184
    api/services/admin/rightrenewals/save.js on lines 142..160
    api/services/admin/rights/save.js on lines 199..217
    api/services/admin/types/save.js on lines 99..117
    api/services/manager/waitingrequests/save.js on lines 232..250
    api/services/user/adjustments/save.js on lines 121..140
    api/services/user/googlecalendars/save.js on lines 56..75
    api/services/user/overtimes/save.js on lines 168..185
    api/services/user/recoverquantities/save.js on lines 81..99
    api/services/user/requests/save.js on lines 447..465
    api/services/user/settings/save.js on lines 134..152

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 82.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status