Sign upLogin

gadael/gadael

View on GitHub
Star
api/services/manager/waitingrequests/get.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function exports has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports = module.exports = function(services, app) {


    const gt = app.utility.gettext;
Severity: Minor
Found in api/services/manager/waitingrequests/get.js - About 1 hr to fix

    Function getResultPromise has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        service.getResultPromise = function(params) {

        var filter = {
            _id: params.id
        };
    Severity: Minor
    Found in api/services/manager/waitingrequests/get.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          for (var i=0; i<object.approvalSteps.length; i++) {
                        object.approvalSteps[i].dispStatus = document.approvalSteps[i].getDispStatus();
                    }
      Severity: Major
      Found in api/services/manager/waitingrequests/get.js and 1 other location - About 1 hr to fix
      api/services/user/requests/get.js on lines 106..108

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              service.app.db.models.Request
        .findOne(filter)
        .populate('events')
        .populate('user.id')
        .populate('absence.distribution')
      Severity: Minor
      Found in api/services/manager/waitingrequests/get.js and 1 other location - About 55 mins to fix
      api/services/user/requests/get.js on lines 38..43

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status