Sign upLogin

gadael/gadael

View on GitHub
Star
modules/apputil.js

Summary

Maintainability
C
1 day
Test Coverage

Function exports has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

exports = module.exports = function(app) {

    if (undefined !== app.utility) {
        return;
    }
Severity: Minor
Found in modules/apputil.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports = module.exports = function(app) {

    if (undefined !== app.utility) {
        return;
    }
Severity: Minor
Found in modules/apputil.js - About 1 hr to fix

    Function checkPathOnRequest has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        app.checkPathOnRequest = function(ctrl) {
        const req = ctrl.req;
        const gt = req.app.utility.gettext;

        const adminResource     = 0 === ctrl.path.indexOf('/rest/admin/') || 0 === ctrl.path.indexOf('/api/admin/');
    Severity: Minor
    Found in modules/apputil.js - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

                  return false;
      Severity: Major
      Found in modules/apputil.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return true;
        Severity: Major
        Found in modules/apputil.js - About 30 mins to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  if (managerResource && (!req.isAuthenticated() || !req.user.canPlayRoleOf('manager'))) {
            ctrl.accessDenied(gt.gettext('Access denied for non managers'));
            return false;
        }
          Severity: Major
          Found in modules/apputil.js and 2 other locations - About 1 hr to fix
          modules/apputil.js on lines 59..62
          modules/apputil.js on lines 64..67

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  if (adminResource && (!req.isAuthenticated() || !req.user.canPlayRoleOf('admin'))) {
            ctrl.accessDenied(gt.gettext('Access denied for non administrators'));
            return false;
        }
          Severity: Major
          Found in modules/apputil.js and 2 other locations - About 1 hr to fix
          modules/apputil.js on lines 64..67
          modules/apputil.js on lines 69..72

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  if (accountResource && (!req.isAuthenticated() || !req.user.canPlayRoleOf('account'))) {
            ctrl.accessDenied(gt.gettext('Access denied for users without absences account'));
            return false;
        }
          Severity: Major
          Found in modules/apputil.js and 2 other locations - About 1 hr to fix
          modules/apputil.js on lines 59..62
          modules/apputil.js on lines 69..72

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status