gadael/gadael

View on GitHub
modules/passport.js

Summary

Maintainability
D
2 days
Test Coverage

Function exports has 198 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports = module.exports = function(app, passport) {

    let loginservices = app.config.company.loginservices;
    let User = app.db.models.User;
    let gt = app.utility.gettext;
Severity: Major
Found in modules/passport.js - About 7 hrs to fix

    Function exports has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
    Open

    exports = module.exports = function(app, passport) {
    
        let loginservices = app.config.company.loginservices;
        let User = app.db.models.User;
        let gt = app.utility.gettext;
    Severity: Minor
    Found in modules/passport.js - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function useGoogleStrategy has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function useGoogleStrategy(request, accessToken, refreshToken, profile, done) {
    
            if (request.user) {
                // already authenticated, but not linked to google account
                if (undefined === request.user.google) {
    Severity: Minor
    Found in modules/passport.js - About 1 hr to fix

      Function useLocalStrategy has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function useLocalStrategy(username, password, done) {
      
              let conditions = {
                  isActive: true,
                  email: username
      Severity: Minor
      Found in modules/passport.js - About 1 hr to fix

        Function useGoogleStrategy has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            function useGoogleStrategy(request, accessToken, refreshToken, profile, done) {
        Severity: Minor
        Found in modules/passport.js - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status