Sign upLogin

gadael/gadael

View on GitHub
Star
public/js/services/beneficiary.js

Summary

Maintainability
D
2 days
Test Coverage

Function init has 187 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    return function init(decimalAdjust, gettext) {


        /**
         * Create graph values
Severity: Major
Found in public/js/services/beneficiary.js - About 7 hrs to fix

    Function createGraphValues has 117 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            function createGraphValues(renewals, requestsPromise)
        {
            var history = [];

            function round(x) {
    Severity: Major
    Found in public/js/services/beneficiary.js - About 4 hrs to fix

      Function processBeneficiary has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              function processBeneficiary($scope, beneficiaryContainer, requests, adjustmentResourceQuery)
        {
            beneficiaryContainer.$promise.then(function onLoadBeneficiary(beneficiary) {
      Severity: Minor
      Found in public/js/services/beneficiary.js - About 1 hr to fix

        Function onLoadBeneficiary has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    beneficiaryContainer.$promise.then(function onLoadBeneficiary(beneficiary) {


                var now = new Date();
        Severity: Minor
        Found in public/js/services/beneficiary.js - About 1 hr to fix

          Function buildRenewalsWithAdjustments has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                      function buildRenewalsWithAdjustments() {


                if (renewals.length <= 0) {
                    return Q.resolve(true);
          Severity: Minor
          Found in public/js/services/beneficiary.js - About 1 hr to fix

            Function buildRequests has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                        function buildRequests() {


                /**
                 * Add all valid interval of the request to the graph dates
            Severity: Minor
            Found in public/js/services/beneficiary.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              history.sort(function (a, b) {
                    if (a.position > b.position) {
                        return 1;
                    }
                    if (a.position < b.position) {
              Severity: Minor
              Found in public/js/services/beneficiary.js and 1 other location - About 55 mins to fix
              public/js/services/timesavingdeposit-edit.js on lines 5..15

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 53.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status