gadael/gadael

View on GitHub
rest/anonymous/invitation.js

Summary

Maintainability
D
1 day
Test Coverage

Function createController has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function createController() {
    ctrlFactory.create.call(this, '/rest/anonymous/invitation');
    var controller = this;


Severity: Major
Found in rest/anonymous/invitation.js - About 2 hrs to fix

    Function controllerAction has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        this.controllerAction = function() {
    
            const gt = controller.req.app.utility.gettext;
    
            getInvitation(controller, controller.req.body.emailToken)
    Severity: Minor
    Found in rest/anonymous/invitation.js - About 1 hr to fix

      Function startPlannings has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function startPlannings(controller, userId, body, invitation) {
          const User = controller.req.app.db.models.User;
          const AccountCollection = controller.req.app.db.models.AccountCollection;
          const AccountScheduleCalendar = controller.req.app.db.models.AccountScheduleCalendar;
          const AccountNWDaysCalendar = controller.req.app.db.models.AccountNWDaysCalendar;
      Severity: Minor
      Found in rest/anonymous/invitation.js - About 1 hr to fix

        Function getController has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function getController() {
        
        
            ctrlFactory.get.call(this, '/rest/anonymous/invitation/:emailToken');
        
        
        Severity: Minor
        Found in rest/anonymous/invitation.js - About 1 hr to fix

          Function controllerAction has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              this.controllerAction = function() {
                  getInvitation(controller, controller.req.params.emailToken)
                  .then(document => {
          
                      let invitation = document.toObject();
          Severity: Minor
          Found in rest/anonymous/invitation.js - About 1 hr to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (body.collection) {
                        let accountCollection = new AccountCollection();
                        accountCollection.account = user.roles.account;
                        accountCollection.rightCollection = body.collection;
                        accountCollection.from = startDate;
            Severity: Major
            Found in rest/anonymous/invitation.js and 2 other locations - About 2 hrs to fix
            rest/anonymous/invitation.js on lines 51..57
            rest/anonymous/invitation.js on lines 59..65

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 84.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (body.scheduleCalendar) {
                        let schedule = new AccountScheduleCalendar();
                        schedule.account = user.roles.account;
                        schedule.calendar = body.scheduleCalendar;
                        schedule.from = startDate;
            Severity: Major
            Found in rest/anonymous/invitation.js and 2 other locations - About 2 hrs to fix
            rest/anonymous/invitation.js on lines 43..49
            rest/anonymous/invitation.js on lines 59..65

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 84.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (invitation.nonWorkingDaysCalendar) {
                        let nonworking = new AccountNWDaysCalendar();
                        nonworking.account = user.roles.account;
                        nonworking.calendar = invitation.nonWorkingDaysCalendar;
                        nonworking.from = startDate;
            Severity: Major
            Found in rest/anonymous/invitation.js and 2 other locations - About 2 hrs to fix
            rest/anonymous/invitation.js on lines 43..49
            rest/anonymous/invitation.js on lines 51..57

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 84.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status