gadael/gadael

View on GitHub
schema/RecoverQuantity.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function exports has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports = module.exports = function(params) {

    const mongoose = params.mongoose;

    var recoverQuantitySchema = new mongoose.Schema({
Severity: Minor
Found in schema/RecoverQuantity.js - About 2 hrs to fix

    Function getInitTask has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        recoverQuantitySchema.statics.getInitTask = function(companyDoc) {
    
            const gt = params.app.utility.gettext;
            let model = this;
    
    
    Severity: Minor
    Found in schema/RecoverQuantity.js - About 1 hr to fix

      Function createDefaults has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              function createDefaults() {
      
                  let all = [
                      {
                          _id: '5740adf51cf1a569643cc530',
      Severity: Minor
      Found in schema/RecoverQuantity.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    return Promise.all(
                        all.map(data => {
                            let recoverQuantity = new model();
                            recoverQuantity.set(data);
                            return recoverQuantity.save();
        Severity: Major
        Found in schema/RecoverQuantity.js and 1 other location - About 1 hr to fix
        schema/RightCollection.js on lines 200..206

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status