Sign upLogin

gadael/gadael

View on GitHub
Star
schema/Right.js

Summary

Maintainability
F
1 wk
Test Coverage

Function exports has 586 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports = module.exports = function(params) {

    const dispunits = params.app.utility.dispunits;
    const mongoose = params.mongoose;
Severity: Major
Found in schema/Right.js - About 2 days to fix

    Function exports has a Cognitive Complexity of 87 (exceeds 5 allowed). Consider refactoring.
    Open

    exports = module.exports = function(params) {

    const dispunits = params.app.utility.dispunits;
    const mongoose = params.mongoose;
    Severity: Minor
    Found in schema/Right.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File Right.js has 590 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict';

const SpecialRightIndex = require('../api/specialrights/index');
    Severity: Major
    Found in schema/Right.js - About 1 day to fix

      Function getInitTask has 94 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          rightSchema.statics.getInitTask = function(company) {

        let model = this;
      Severity: Major
      Found in schema/Right.js - About 3 hrs to fix

        Function saveRight has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                function saveRight(rightData) {

            function getRenewal() {

                if (undefined === rightData.renewal) {
        Severity: Minor
        Found in schema/Right.js - About 1 hr to fix

          Function getInitialQuantityInPeriod has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              rightSchema.methods.getInitialQuantityInPeriod = function(user, dtstart, dtend, field) {

        let right = this;

        if (null === right.quantity) {
          Severity: Minor
          Found in schema/Right.js - About 1 hr to fix

            Function validateRules has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                rightSchema.methods.validateRules = function(renewal, user, dtstart, dtend, timeCreated) {
            Severity: Minor
            Found in schema/Right.js - About 35 mins to fix

              Avoid too many return statements within this function.
              Open

                      return Promise.reject('Unexpected consumption type '+right.consumption);
              Severity: Major
              Found in schema/Right.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return elem.getLength();
                Severity: Major
                Found in schema/Right.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                  return null;
                  Severity: Major
                  Found in schema/Right.js - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        rightSchema.methods.addCollectionBeneficiary = function addCollectionBeneficiary(collection) {
        let model = this.model('Beneficiary');

        let id = collection;
        if (undefined !== collection._id) {
                    Severity: Major
                    Found in schema/Right.js and 1 other location - About 6 hrs to fix
                    schema/Right.js on lines 490..507

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 155.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        rightSchema.methods.addUserBeneficiary = function addUserBeneficiary(user) {
        let model = this.model('Beneficiary');

        let id = user;
        if (undefined !== user._id) {
                    Severity: Major
                    Found in schema/Right.js and 1 other location - About 6 hrs to fix
                    schema/Right.js on lines 463..480

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 155.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        rightSchema.methods.canLinkToCollection = function() {
        let model = this.model('Beneficiary');

        return model.find()
        .where('right', this._id)
                    Severity: Major
                    Found in schema/Right.js and 1 other location - About 4 hrs to fix
                    schema/Right.js on lines 439..453

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 117.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        rightSchema.methods.canLinkToUser = function() {
        let model = this.model('Beneficiary');

        return model.find()
        .where('right', this._id)
                    Severity: Major
                    Found in schema/Right.js and 1 other location - About 4 hrs to fix
                    schema/Right.js on lines 417..431

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 117.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    for (let i=0; i<all.length; i++) {
                    let beneficiary = beneficiaries[i];
                    let users       = all[i];

                    users.forEach(push.bind(beneficiary));
                    Severity: Major
                    Found in schema/Right.js and 1 other location - About 1 hr to fix
                    api/services/admin/compulsoryleaves/save.js on lines 367..372

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 68.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 4 locations. Consider refactoring.
                    Open

                            return Beneficiary.find()
        .where('right', this._id)
        .exec()
        .then(beneficiaries => {
            let removePromises = [];
                    Severity: Major
                    Found in schema/Right.js and 3 other locations - About 1 hr to fix
                    api/services/user/requests/save.js on lines 210..222
                    schema/Right.js on lines 163..174
                    schema/Right_Renewal.js on lines 99..111

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 62.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 4 locations. Consider refactoring.
                    Open

                            return RightRenewal.find()
        .where('right', right._id)
        .exec()
        .then(renewals => {
            let removePromises = [];
                    Severity: Major
                    Found in schema/Right.js and 3 other locations - About 1 hr to fix
                    api/services/user/requests/save.js on lines 210..222
                    schema/Right.js on lines 184..195
                    schema/Right_Renewal.js on lines 99..111

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 62.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 4 locations. Consider refactoring.
                    Open

                        rightSchema.methods.getRenewalsQuery = function() {
        return this.model('RightRenewal')
            .find()
            .where('right').equals(this._id);
    };
                    Severity: Major
                    Found in schema/Right.js and 3 other locations - About 1 hr to fix
                    schema/User_Account.js on lines 77..82
                    schema/User_Account.js on lines 88..92
                    schema/User_Account.js on lines 99..103

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 62.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if (!params.finish) {
            params.finish = new Date(params.start);
            params.finish.setFullYear(params.finish.getFullYear() + 1);
        }
                    Severity: Minor
                    Found in schema/Right.js and 1 other location - About 55 mins to fix
                    modules/getExpandedEra.js on lines 13..16

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 53.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status