Sign upLogin

gadael/gadael

View on GitHub
Star
schema/Right_Renewal.js

Summary

Maintainability
F
1 wk
Test Coverage

Function exports has 682 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports = module.exports = function(params) {

    var mongoose = params.mongoose;
Severity: Major
Found in schema/Right_Renewal.js - About 3 days to fix

    File Right_Renewal.js has 687 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict';

const consumptionHistory = require('../modules/consumptionHistory');
const util = require('util');
    Severity: Major
    Found in schema/Right_Renewal.js - About 1 day to fix

      Function exports has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
      Open

      exports = module.exports = function(params) {

    var mongoose = params.mongoose;
      Severity: Minor
      Found in schema/Right_Renewal.js - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function saveUserRenewalStat has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          rightRenewalSchema.methods.saveUserRenewalStat = function(user, beneficiary, stat) {
        let renewal = this;
        let UserRenewalStat = renewal.model('UserRenewalStat');

        return UserRenewalStat.find({
      Severity: Minor
      Found in schema/Right_Renewal.js - About 1 hr to fix

        Function getUserQuantity has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            rightRenewalSchema.methods.getUserQuantity = function(user, moment) {

        let renewal = this;

        if (undefined === moment) {
        Severity: Minor
        Found in schema/Right_Renewal.js - About 1 hr to fix

          Function getUserQuantityStats has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              rightRenewalSchema.methods.getUserQuantityStats = function(user) {


        let renewal = this;
          Severity: Minor
          Found in schema/Right_Renewal.js - About 1 hr to fix

            Function createRightAdjustments has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                rightRenewalSchema.methods.createRightAdjustments = function(right) {

        var renewal = this;

        if (renewal.finish <= new Date()) {
            Severity: Minor
            Found in schema/Right_Renewal.js - About 1 hr to fix

              Function getSavingPeriod has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  rightRenewalSchema.methods.getSavingPeriod = function(right) {

        if (undefined === right || null === right) {
            if (undefined !== this.populated('right')) {
                right = this.right;
              Severity: Minor
              Found in schema/Right_Renewal.js - About 1 hr to fix

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        return Adjustment.find()
        .where('rightRenewal').equals(this._id)
        .where('autoAdjustment').equals(true)
        .exec()
        .then(adjustments => {
                Severity: Major
                Found in schema/Right_Renewal.js and 3 other locations - About 1 hr to fix
                api/services/user/requests/save.js on lines 210..222
                schema/Right.js on lines 163..174
                schema/Right.js on lines 184..195

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 62.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    rightRenewalSchema.methods.getUserAbsenceConsumedQuantity = function(user, moment) {
        return this.getUserAbsenceRequestsQuantity(user, moment)
        .then(requests => {
            return requests.consumed;
        });
                Severity: Major
                Found in schema/Right_Renewal.js and 1 other location - About 1 hr to fix
                schema/Right_Renewal.js on lines 670..675

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 59.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    rightRenewalSchema.methods.getUserWaitingQuantity = function(user, moment) {
        return this.getUserAbsenceRequestsQuantity(user, moment)
        .then(requests => {
            return requests.waiting;
        });
                Severity: Major
                Found in schema/Right_Renewal.js and 1 other location - About 1 hr to fix
                schema/Right_Renewal.js on lines 653..658

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 59.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status