gadael/gadael

View on GitHub
schema/User.js

Summary

Maintainability
F
1 wk
Test Coverage

Function exports has 568 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports = module.exports = function(params) {

    let mongoose = params.mongoose;
    let userSchema = new mongoose.Schema({
        password: { type: String, select: false },
Severity: Major
Found in schema/User.js - About 2 days to fix

    File User.js has 577 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict';
    
    const bcrypt = require('bcryptjs');
    const Charlatan = require('charlatan');
    const util = require('util');
    Severity: Major
    Found in schema/User.js - About 1 day to fix

      Function exports has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring.
      Open

      exports = module.exports = function(params) {
      
          let mongoose = params.mongoose;
          let userSchema = new mongoose.Schema({
              password: { type: String, select: false },
      Severity: Minor
      Found in schema/User.js - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function canSpoofUser has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          userSchema.methods.canSpoofUser = function(user) {
      
              let userDocument = this;
      
              return new Promise((resolve, reject) => {
      Severity: Minor
      Found in schema/User.js - About 1 hr to fix

        Function saveAdmin has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            userSchema.methods.saveAdmin = function(adminProperties) {
        
                let userDocument = this;
        
                return new Promise((resolve, reject) => {
        Severity: Minor
        Found in schema/User.js - About 1 hr to fix

          Function saveManager has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              userSchema.methods.saveManager = function(managerProperties) {
          
                  let userDocument = this;
          
                  return new Promise((resolve, reject) => {
          Severity: Minor
          Found in schema/User.js - About 1 hr to fix

            Function saveAccount has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                userSchema.methods.saveAccount = function(accountProperties) {
            
                    let userDocument = this;
            
                    return new Promise((resolve, reject) => {
            Severity: Minor
            Found in schema/User.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  userSchema.methods.saveAdmin = function(adminProperties) {
              
                      let userDocument = this;
              
                      return new Promise((resolve, reject) => {
              Severity: Major
              Found in schema/User.js and 1 other location - About 1 day to fix
              schema/User.js on lines 543..585

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 262.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  userSchema.methods.saveManager = function(managerProperties) {
              
                      let userDocument = this;
              
                      return new Promise((resolve, reject) => {
              Severity: Major
              Found in schema/User.js and 1 other location - About 1 day to fix
              schema/User.js on lines 440..482

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 262.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  userSchema.methods.getAccount = function() {
              
                      let user = this;
              
                      if (!user.roles.account) {
              Severity: Major
              Found in schema/User.js and 1 other location - About 3 hrs to fix
              schema/User.js on lines 733..745

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 98.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  userSchema.methods.getManager = function() {
              
                      let user = this;
              
                      if (!user.roles.manager) {
              Severity: Major
              Found in schema/User.js and 1 other location - About 3 hrs to fix
              schema/User.js on lines 709..722

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 98.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status