Sign upLogin

gaearon/dnd-core

View on GitHub
Star

Showing 7 of 11 total issues

Function dragOperation has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function dragOperation(state = initialState, action) {
  switch (action.type) {
    case BEGIN_DRAG:
      return {
        ...state,
Severity: Minor
Found in src/reducers/dragOperation.js - About 2 hrs to fix

    Function dirtyHandlerIds has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function dirtyHandlerIds(state = NONE, action, dragOperation) {
  switch (action.type) {
    case HOVER:
      break;
    case ADD_SOURCE:
    Severity: Minor
    Found in src/reducers/dirtyHandlerIds.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function dirtyHandlerIds has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export default function dirtyHandlerIds(state = NONE, action, dragOperation) {
  switch (action.type) {
    case HOVER:
      break;
    case ADD_SOURCE:
    Severity: Minor
    Found in src/reducers/dirtyHandlerIds.js - About 1 hr to fix

      Function drop has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function drop() {
  const monitor = this.getMonitor();
  const registry = this.getRegistry();
  invariant(
    monitor.isDragging(),
      Severity: Minor
      Found in src/actions/dragDrop.js - About 1 hr to fix

        Function subscribeToStateChange has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          subscribeToStateChange(listener, options = {}) {
    const { handlerIds } = options;
    invariant(
      typeof listener === 'function',
      'listener must be a function.',
        Severity: Minor
        Found in src/DragDropMonitor.js - About 1 hr to fix

          Avoid too many return statements within this function.
          Open

                return index > -1;
          Severity: Major
          Found in src/DragDropMonitor.js - About 30 mins to fix

            Function beginDrag has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            export function beginDrag(sourceIds, options = { publishSource: true, clientOffset: null }) {
  const { publishSource, clientOffset, getSourceClientOffset } = options;
  invariant(isArray(sourceIds), 'Expected sourceIds to be an array.');

  const monitor = this.getMonitor();
            Severity: Minor
            Found in src/actions/dragDrop.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language