Sign upLogin

gagoar/SrBuj

View on GitHub
Star
lib/assets/javascripts/SrBuj.js

Summary

Maintainability
C
1 day
Test Coverage

File SrBuj.js has 252 lines of code (exceeds 250 allowed). Consider refactoring.
Open

(function ($, undefined) {
    /**
     * Better Unobtrusive  javascript request for Jquery
     * https://github.com/gagoar/SrBuj
     *
Severity: Minor
Found in lib/assets/javascripts/SrBuj.js - About 2 hrs to fix

    Function success has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            success: function (e, data, status, xhr, user_options) {
          if ( xhr ){
            var notify = {};
            for ( var attr in $.SrBuj.notifyHeaders )
              if ( $.SrBuj.notifyHeaders.hasOwnProperty(attr) ) {
    Severity: Minor
    Found in lib/assets/javascripts/SrBuj.js - About 1 hr to fix

      Function link has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                link: function (user_options){
            /* This function will create a link with options, trigger it and remove the link afterwards
             * user_options must be a hash (Obj) with key: value without the data word
             * if the hash contain more keys, these will be integrated too as data-key form. Example:
             * { target: 'modal', error: 'modal', modal: true, href: '/admin/request'}
      Severity: Minor
      Found in lib/assets/javascripts/SrBuj.js - About 1 hr to fix

        Function getOptions has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                getOptions: function (el, user_options) {
            user_options = user_options || {};
            var options = {},
                $el = $(user_options.el || el).present(),
                el_options = {
        Severity: Minor
        Found in lib/assets/javascripts/SrBuj.js - About 1 hr to fix

          Function success has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  success: function (e, data, status, xhr, user_options) {
          Severity: Minor
          Found in lib/assets/javascripts/SrBuj.js - About 35 mins to fix

            Function fail has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    fail: function (e, data, status, error_code, user_options) {
            Severity: Minor
            Found in lib/assets/javascripts/SrBuj.js - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          for ( var attr in $.SrBuj.notifyHeaders )
              if ( $.SrBuj.notifyHeaders.hasOwnProperty(attr) ) {
                notify[attr] = xhr.getResponseHeader($.SrBuj.notifyHeaders[attr]);
              }
              Severity: Major
              Found in lib/assets/javascripts/SrBuj.js and 1 other location - About 1 hr to fix
              lib/assets/javascripts/SrBuj.js on lines 184..187

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 72.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          for (var attr in $.SrBuj.notifyHeaders)
              if ($.SrBuj.notifyHeaders.hasOwnProperty(attr)) {
                notify[attr] = data.getResponseHeader($.SrBuj.notifyHeaders[attr]);
              }
              Severity: Major
              Found in lib/assets/javascripts/SrBuj.js and 1 other location - About 1 hr to fix
              lib/assets/javascripts/SrBuj.js on lines 135..138

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 72.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status