Sign upLogin

gardejo/js-kancolle-logistics-visualizer

View on GitHub
Star
lib/chart.material.js

Summary

Maintainability
C
1 day
Test Coverage

Function buildOption has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

kclv.Chart.Line.prototype.buildOption = function() {
    var material = this.table.kind,
        kind = kclv.Game.Materials.getKindOf(material),
        configuration = this.cascadeHorizontalConfiguration(kind, 'Materials'),
        option =
Severity: Minor
Found in lib/chart.material.js - About 1 hr to fix

    Function buildOption has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    kclv.Chart.Line.prototype.buildOption = function() {
    var material = this.table.kind,
        kind = kclv.Game.Materials.getKindOf(material),
        configuration = this.cascadeHorizontalConfiguration(kind, 'Materials'),
        option =
    Severity: Minor
    Found in lib/chart.material.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function buildOption has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    kclv.Chart.Candlestick.prototype.buildOption = function() {
    var material = this.table.kind,
        kind = kclv.Game.Materials.getKindOf(material),
        configuration = this.cascadeHorizontalConfiguration(kind, 'Materials'),
        option =
    Severity: Minor
    Found in lib/chart.material.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        var material = this.table.kind,
        kind = kclv.Game.Materials.getKindOf(material),
        configuration = this.cascadeHorizontalConfiguration(kind, 'Materials'),
        option =
            kclv.Chart.Base.prototype.buildOption.call(this, configuration);
    Severity: Major
    Found in lib/chart.material.js and 1 other location - About 2 hrs to fix
    lib/chart.material.js on lines 123..127

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        var material = this.table.kind,
        kind = kclv.Game.Materials.getKindOf(material),
        configuration = this.cascadeHorizontalConfiguration(kind, 'Materials'),
        option =
            kclv.Chart.Base.prototype.buildOption.call(this, configuration);
    Severity: Major
    Found in lib/chart.material.js and 1 other location - About 2 hrs to fix
    lib/chart.material.js on lines 38..42

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 16 locations. Consider refactoring.
    Open

    kclv.Chart.Candlestick = function(table) {
    kclv.Chart.Base.call(this, 'Candlestick', table);

    return;
};
    Severity: Major
    Found in lib/chart.material.js and 15 other locations - About 40 mins to fix
    lib/chart.js on lines 373..377
    lib/chart.js on lines 393..397
    lib/chart.js on lines 435..439
    lib/chart.js on lines 455..459
    lib/chart.js on lines 475..479
    lib/chart.js on lines 495..499
    lib/chart.js on lines 515..519
    lib/chart.js on lines 535..539
    lib/chart.js on lines 555..559
    lib/chart.js on lines 575..579
    lib/chart.js on lines 595..599
    lib/chart.material.js on lines 105..109
    lib/chart.ship.js on lines 21..25
    lib/chart.ship.js on lines 108..112
    lib/chart.ship.js on lines 129..133

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 16 locations. Consider refactoring.
    Open

    kclv.Chart.Line = function(table) {
    kclv.Chart.Base.call(this, 'Line', table);

    return;
};
    Severity: Major
    Found in lib/chart.material.js and 15 other locations - About 40 mins to fix
    lib/chart.js on lines 373..377
    lib/chart.js on lines 393..397
    lib/chart.js on lines 435..439
    lib/chart.js on lines 455..459
    lib/chart.js on lines 475..479
    lib/chart.js on lines 495..499
    lib/chart.js on lines 515..519
    lib/chart.js on lines 535..539
    lib/chart.js on lines 555..559
    lib/chart.js on lines 575..579
    lib/chart.js on lines 595..599
    lib/chart.material.js on lines 22..26
    lib/chart.ship.js on lines 21..25
    lib/chart.ship.js on lines 108..112
    lib/chart.ship.js on lines 129..133

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status