Sign upLogin

gardejo/js-kancolle-logistics-visualizer

View on GitHub
Star
lib/table.ship.js

Summary

Maintainability
C
1 day
Test Coverage

Function buildRows has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

kclv.Table.Ships.Base.prototype.buildRows = function() {
    var indexOf = this.getClassificationDictionary_(),
        attributeOf = this.relation.getAttributes(),
        relation = this.canonizeRelation_(attributeOf),
        mothballLevel =
Severity: Minor
Found in lib/table.ship.js - About 1 hr to fix

    Function buildRows has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    kclv.Table.Ships.Bubble.prototype.buildRows = function() {
    var roster = this.buildRoster_(),
        threshold =
            kclv.Configuration.get('chart.Ships.vertical.level', true) || 0,
        label = kclv.Configuration.get([
    Severity: Minor
    Found in lib/table.ship.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      kclv.Table.Ships.Bubble.prototype.minimum = function(indices) {
    return kclv.Array.minimum(this.rows, indices, this);
};
      Severity: Major
      Found in lib/table.ship.js and 1 other location - About 1 hr to fix
      lib/table.ship.js on lines 358..360

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      kclv.Table.Ships.Scatter = function(relation, option) {
    kclv.Table.Ships.Base.call(this, relation, option, true);

    return;
};
      Severity: Major
      Found in lib/table.ship.js and 1 other location - About 1 hr to fix
      lib/table.ship.js on lines 492..496

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      kclv.Table.Ships.Bubble.prototype.maximum = function(indices) {
    return kclv.Array.maximum(this.rows, indices, this);
};
      Severity: Major
      Found in lib/table.ship.js and 1 other location - About 1 hr to fix
      lib/table.ship.js on lines 372..374

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      kclv.Table.Ships.Histogram = function(relation, option) {
    kclv.Table.Ships.Base.call(this, relation, option, false);

    return;
};
      Severity: Major
      Found in lib/table.ship.js and 1 other location - About 1 hr to fix
      lib/table.ship.js on lines 429..433

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 16 locations. Consider refactoring.
      Open

      kclv.Table.Ships.Scatter.prototype =
    Object.create(kclv.Table.Ships.Base.prototype);
      Severity: Major
      Found in lib/table.ship.js and 15 other locations - About 35 mins to fix
      lib/projector.js on lines 122..123
      lib/projector.js on lines 190..191
      lib/table.material.js on lines 96..97
      lib/table.material.js on lines 224..225
      lib/table.ship.js on lines 237..238
      lib/table.ship.js on lines 497..498
      lib/tokenizer.js on lines 333..334
      lib/tokenizer.js on lines 370..371
      lib/tokenizer.js on lines 437..438
      lib/tokenizer.js on lines 492..493
      lib/tokenizer.js on lines 542..543
      lib/tokenizer.js on lines 601..602
      lib/tokenizer.js on lines 648..649
      lib/tokenizer.js on lines 692..693
      lib/tokenizer.js on lines 760..761

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 16 locations. Consider refactoring.
      Open

      kclv.Table.Ships.Histogram.prototype =
    Object.create(kclv.Table.Ships.Base.prototype);
      Severity: Major
      Found in lib/table.ship.js and 15 other locations - About 35 mins to fix
      lib/projector.js on lines 122..123
      lib/projector.js on lines 190..191
      lib/table.material.js on lines 96..97
      lib/table.material.js on lines 224..225
      lib/table.ship.js on lines 237..238
      lib/table.ship.js on lines 434..435
      lib/tokenizer.js on lines 333..334
      lib/tokenizer.js on lines 370..371
      lib/tokenizer.js on lines 437..438
      lib/tokenizer.js on lines 492..493
      lib/tokenizer.js on lines 542..543
      lib/tokenizer.js on lines 601..602
      lib/tokenizer.js on lines 648..649
      lib/tokenizer.js on lines 692..693
      lib/tokenizer.js on lines 760..761

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 16 locations. Consider refactoring.
      Open

      kclv.Table.Ships.Bubble.prototype =
    Object.create(kclv.Table.Ships.Base.prototype);
      Severity: Major
      Found in lib/table.ship.js and 15 other locations - About 35 mins to fix
      lib/projector.js on lines 122..123
      lib/projector.js on lines 190..191
      lib/table.material.js on lines 96..97
      lib/table.material.js on lines 224..225
      lib/table.ship.js on lines 434..435
      lib/table.ship.js on lines 497..498
      lib/tokenizer.js on lines 333..334
      lib/tokenizer.js on lines 370..371
      lib/tokenizer.js on lines 437..438
      lib/tokenizer.js on lines 492..493
      lib/tokenizer.js on lines 542..543
      lib/tokenizer.js on lines 601..602
      lib/tokenizer.js on lines 648..649
      lib/tokenizer.js on lines 692..693
      lib/tokenizer.js on lines 760..761

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status