Sign upLogin

garrettw/noair

View on GitHub
Star

Showing 8 of 8 total issues

Function fire has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function fire($eventName, Event $event, $result = null)
    {
        $subs = $this->subscribers[$eventName];
        unset($subs[0]);
Severity: Minor
Found in src/Manager.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method subscribe has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function subscribe($newhandler = null)
    {
        if (is_array($newhandler)) {
            $this->handlers = array_merge($this->handlers, $newhandler);
            $this->subResults = $this->mediator->subscribe($newhandler);
Severity: Minor
Found in src/Observer.php - About 1 hr to fix

    Method add has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function add($eventName, $interval, array $handler)
    {
        // scaffold if not exist
        if (!$this->hasSubscribers($eventName)) {
            $this->subscribers[$eventName] = [
    Severity: Minor
    Found in src/Manager.php - About 1 hr to fix

      Function subscribe has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function subscribe($newhandler = null)
    {
        if (is_array($newhandler)) {
            $this->handlers = array_merge($this->handlers, $newhandler);
            $this->subResults = $this->mediator->subscribe($newhandler);
      Severity: Minor
      Found in src/Observer.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function subscribe has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function subscribe(array $eventHandlers)
    {
        $results = [];

        foreach ($eventHandlers as $eventName => $handler) {
      Severity: Minor
      Found in src/Mediator.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function arraySearchDeep has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected static function arraySearchDeep($needle, array $haystack)
    {
        if (is_array($needle)
            && !is_callable($needle)
            // and if all key/value pairs in $needle have exact matches in $haystack
      Severity: Minor
      Found in src/Manager.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __set has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function __set($name, $val)
    {
        switch ($name) {
            case 'previousResult':
                $this->previousResults[] = $val;
      Severity: Minor
      Found in src/Event.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function unsubscribe has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function unsubscribe(array $eventHandlers)
    {
        foreach ($eventHandlers as $eventName => $callback) {
            if ($callback == '*') {
                // we're unsubscribing all of $eventName
      Severity: Minor
      Found in src/Mediator.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language