gedankenstuecke/jupyter-gallery

View on GitHub

Showing 4 of 8 total issues

File views.py has 266 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import logging
from django.contrib import messages
from django.contrib.auth.decorators import login_required
from django.contrib.auth import login, logout
from django.shortcuts import render, redirect
Severity: Minor
Found in main/views.py - About 2 hrs to fix

    Function oh_code_to_member has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    def oh_code_to_member(code):
        """
        Exchange code for token, use this to create and return OpenHumansMember.
        If a matching OpenHumansMember exists, update and return it.
        """
    Severity: Minor
    Found in main/helpers.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function create has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def create(cls, oh_id, oh_username,
    Severity: Minor
    Found in open_humans/models.py - About 35 mins to fix

      Function add_notebook has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      def add_notebook(request, notebook_id):
          oh_member = request.user.oh_member
          try:
              oh_member_data = api.exchange_oauth2_member(
                                      oh_member.get_access_token())
      Severity: Minor
      Found in main/views.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language