Sign upLogin

geekq/workflow

View on GitHub
Star

Showing 6 of 13 total issues

Method condition_applicable? has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def condition_applicable?(object, event_arguments)
      if condition
        if condition.is_a?(Symbol)
          m = object.method(condition)
          # Conditionals can now take the arguments of the trasition action into account #227
Severity: Minor
Found in lib/workflow/event.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run_before_transition has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def run_before_transition(from, to, event, *args, **kwargs)
Severity: Minor
Found in lib/workflow.rb - About 35 mins to fix

    Method run_after_transition has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def run_after_transition(from, to, event, *args, **kwargs)
    Severity: Minor
    Found in lib/workflow.rb - About 35 mins to fix

      Method run_on_exit has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def run_on_exit(state, new_state, triggering_event, *args, **kwargs)
      Severity: Minor
      Found in lib/workflow.rb - About 35 mins to fix

        Method run_on_transition has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def run_on_transition(from, to, event, *args, **kwargs)
        Severity: Minor
        Found in lib/workflow.rb - About 35 mins to fix

          Method run_on_entry has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def run_on_entry(state, prior_state, triggering_event, *args, **kwargs)
          Severity: Minor
          Found in lib/workflow.rb - About 35 mins to fix
            Severity
            Category
            Status
            Source
            Language