Sign upLogin

gems-uff/sapos

View on GitHub
Star
app/assets/javascripts/form_fields/config_values.js

Summary

Maintainability
D
2 days
Test Coverage

Function config_form_field_values has 118 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function config_form_field_values(form_field, field, options) {
  let r = (Math.random() + 1).toString(36).substring(7);
  let visible = options["visible"] === false ? `style="display:none;"`: "";
  let main_id = `${form_field.baseid}_${field}_main_id_${r}`
  let div_id = `${form_field.baseid}_${field}_div_${r}`
Severity: Major
Found in app/assets/javascripts/form_fields/config_values.js - About 4 hrs to fix

    Function postRender has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        postRender: () => {
      $(`#${div_id} table input`).on('change', function() {
        form_field.data[field] = $(`#${div_id} table input`).map((i, el) => $(el).val()).toArray();
        form_field.save_config();
      })
    Severity: Minor
    Found in app/assets/javascripts/form_fields/config_values.js - About 1 hr to fix

      Function config_form_field_values has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      function config_form_field_values(form_field, field, options) {
  let r = (Math.random() + 1).toString(36).substring(7);
  let visible = options["visible"] === false ? `style="display:none;"`: "";
  let main_id = `${form_field.baseid}_${field}_main_id_${r}`
  let div_id = `${form_field.baseid}_${field}_div_${r}`
      Severity: Minor
      Found in app/assets/javascripts/form_fields/config_values.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function validate has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          validate: () => {
      is_required = options["required"]
      non_blank = options["non_blank"]
      let fielddata = form_field.data[field] || []
      let result = true;
      Severity: Minor
      Found in app/assets/javascripts/form_fields/config_values.js - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                $(`#${form_field.baseid}_${field}_${r} a`).on('click', function() {
          $(this).closest('tbody').remove();
          form_field.data[field] = $(`#${div_id} table input`).map((i, el) => $(el).val()).toArray();
          form_field.save_config();
          return false;
        Severity: Major
        Found in app/assets/javascripts/form_fields/config_values.js and 1 other location - About 3 hrs to fix
        app/assets/javascripts/form_fields/config_values.js on lines 56..61

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              $(`#${div_id} table a`).on('click', function() {
        $(this).closest('tbody').remove();
        form_field.data[field] = $(`#${div_id} table input`).map((i, el) => $(el).val()).toArray();
        form_field.save_config();
        return false;
        Severity: Major
        Found in app/assets/javascripts/form_fields/config_values.js and 1 other location - About 3 hrs to fix
        app/assets/javascripts/form_fields/config_values.js on lines 78..83

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              $(`#${div_id} table input`).on('change', function() {
        form_field.data[field] = $(`#${div_id} table input`).map((i, el) => $(el).val()).toArray();
        form_field.save_config();
      })
        Severity: Major
        Found in app/assets/javascripts/form_fields/config_values.js and 1 other location - About 2 hrs to fix
        app/assets/javascripts/form_fields/config_values.js on lines 84..87

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                $(`#${form_field.baseid}_${field}_${r} input`).on('change', function() {
          form_field.data[field] = $(`#${div_id} table input`).map((i, el) => $(el).val()).toArray();
          form_field.save_config();
        })
        Severity: Major
        Found in app/assets/javascripts/form_fields/config_values.js and 1 other location - About 2 hrs to fix
        app/assets/javascripts/form_fields/config_values.js on lines 51..54

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status