Sign upLogin

genediazjr/knexshelf

View on GitHub
Star
lib/queries.js

Summary

Maintainability
D
1 day
Test Coverage

Function defaults has a Cognitive Complexity of 78 (exceeds 5 allowed). Consider refactoring.
Wontfix

exports.defaults = function (schema) {

    if (!lib.internals.models[schema.schema.name]) {
        lib.internals.models[schema.schema.name] = {};
    }
Severity: Minor
Found in lib/queries.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function defaults has 277 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

exports.defaults = function (schema) {

    if (!lib.internals.models[schema.schema.name]) {
        lib.internals.models[schema.schema.name] = {};
    }
Severity: Major
Found in lib/queries.js - About 1 day to fix

    Function browse has 70 lines of code (exceeds 25 allowed). Consider refactoring.
    Wontfix

        defaults.browse = async function (query, opts) {

        query = query || {};
        opts = opts || {};
    Severity: Major
    Found in lib/queries.js - About 2 hrs to fix

      File queries.js has 281 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /* eslint complexity: 0 */
'use strict';

const lib = require('.');
      Severity: Minor
      Found in lib/queries.js - About 2 hrs to fix

        Function update has 51 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            defaults.update = async function (params, payload, opts) {

        params = params || {};
        payload = payload || {};
        opts = opts || {};
        Severity: Major
        Found in lib/queries.js - About 2 hrs to fix

          Function delete has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              defaults.delete = async function (params, opts) {

        params = params || {};
        opts = opts || {};
          Severity: Minor
          Found in lib/queries.js - About 1 hr to fix

            Function obtain has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                defaults.obtain = async function (params, opts) {

        if (!params) {

            return null;
            Severity: Minor
            Found in lib/queries.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          try {
                res = await fetch.fetchAll(fetchOpts);
            }
            catch (e) {
                if (Object.keys(lib.internals.subModels).length) {
              Severity: Major
              Found in lib/queries.js and 1 other location - About 3 hrs to fix
              lib/queries.js on lines 109..118

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 112.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          try {
                res = await fetch.fetchPage(fetchOpts);

            }
            catch (e) {
              Severity: Major
              Found in lib/queries.js and 1 other location - About 3 hrs to fix
              lib/queries.js on lines 122..130

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 112.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status