Sign upLogin

gerich-home/it-depends

View on GitHub
Star
performance-tests/scenarios/computedSubscription.js

Summary

Maintainability
C
1 day
Test Coverage

Function exports has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(subscribersCount) {
    Benchmark.prototype.args = {
        subscribersCount: subscribersCount,
        ko: ko,
        itDepends: itDepends
Severity: Minor
Found in performance-tests/scenarios/computedSubscription.js - About 1 hr to fix

Unnecessary semicolon.
Open

        };
Severity: Minor
Found in performance-tests/scenarios/computedSubscription.js by eslint

disallow unnecessary semicolons (no-extra-semi)

Typing mistakes and misunderstandings about where semicolons are required can lead to semicolons that are unnecessary. While not technically an error, extra semicolons can cause confusion when reading code.

Rule Details

This rule disallows unnecessary semicolons.

Examples of incorrect code for this rule:

/*eslint no-extra-semi: "error"*/

var x = 5;;

function foo() {
    // code
};

Examples of correct code for this rule:

/*eslint no-extra-semi: "error"*/

var x = 5;

var foo = function() {
    // code
};

When Not To Use It

If you intentionally use extra semicolons then you can disable this rule.

Related Rules

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    suite.add('itDepends', function() {
        var subscriptions = [];
        
        for (var i = 0; i < subscribersCount; i++) {
            subscriptions.push(idcomputed.onChange(_noop()));
Severity: Major
Found in performance-tests/scenarios/computedSubscription.js and 3 other locations - About 4 hrs to fix
performance-tests/scenarios/computedSubscription.js on lines 31..43
performance-tests/scenarios/observableSubscription.js on lines 29..41
performance-tests/scenarios/observableSubscription.js on lines 43..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 121.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    suite.add('knockout', function() {
        var subscriptions = [];
        
        for (var i = 0; i < subscribersCount; i++) {
            subscriptions.push(kocomputed.subscribe(_noop()));
Severity: Major
Found in performance-tests/scenarios/computedSubscription.js and 3 other locations - About 4 hrs to fix
performance-tests/scenarios/computedSubscription.js on lines 45..57
performance-tests/scenarios/observableSubscription.js on lines 29..41
performance-tests/scenarios/observableSubscription.js on lines 43..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 121.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status