getlackey/lackey-cms

View on GitHub
lib/utils/index.js

Summary

Maintainability
C
1 day
Test Coverage

File index.js has 287 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* eslint no-underscore-dangle:0, no-process-exit:0 */
/* jslint node:true, esnext:true */
/* globals LACKEY_PATH */
'use strict';

Severity: Minor
Found in lib/utils/index.js - About 2 hrs to fix

    Function moduleInterface has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.moduleInterface = function (modulePath, moduleName) {
    
        let api = {
            /**
             * Loads module model
    Severity: Minor
    Found in lib/utils/index.js - About 1 hr to fix

      Function write has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      exports.write = function (filePathOrHandle, content, encoding, position) {
          SCli.debug(__MODULE_NAME, 'Write ' + filePathOrHandle);
          return new Promise((resolve, reject) => {
              let callback = (err) => {
                  SCli.debug(__MODULE_NAME, 'Wrote ' + (err ? 'with' : 'without') + ' error');
      Severity: Minor
      Found in lib/utils/index.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function stats has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      exports.stats = function (filePath) {
          return new Promise((resolve, reject) => {
              fs.stat(filePath, (err, stats) => {
                  if (err) {
                      if (err.code === 'ENOENT') {
      Severity: Minor
      Found in lib/utils/index.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function moduleInterface has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      exports.moduleInterface = function (modulePath, moduleName) {
      
          let api = {
              /**
               * Loads module model
      Severity: Minor
      Found in lib/utils/index.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getProjectPath has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      exports.getProjectPath = function () {
      
          if (projectPath) {
              return projectPath;
          }
      Severity: Minor
      Found in lib/utils/index.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      exports.isDir = function (filePath) {
          return exports
              .stats(filePath)
              .then((stats) => {
                  return (stats && stats.isDirectory());
      Severity: Major
      Found in lib/utils/index.js and 1 other location - About 1 hr to fix
      lib/utils/index.js on lines 327..334

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      exports.exists = function (filePath) {
          return exports
              .stats(filePath)
              .then((stats) => {
                  return (stats && stats.isFile());
      Severity: Major
      Found in lib/utils/index.js and 1 other location - About 1 hr to fix
      lib/utils/index.js on lines 341..348

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status