Sign upLogin

getlackey/lackey-cms

View on GitHub
Star
modules/cms/client/js/manager/gallery.ui.js

Summary

Maintainability
D
2 days
Test Coverage

File gallery.ui.js has 301 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* eslint no-cond-assign:0, no-new:0, no-alert:0 */
/* jslint browser:true, node:true, esnext:true */
'use strict';
/*
    Copyright 2016 Enigma Marketing Services Limited
Severity: Minor
Found in modules/cms/client/js/manager/gallery.ui.js - About 3 hrs to fix

    Function alternative has 71 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        alternative() {
        let self = this;
        return template
            .redraw(lackey.hook('sources', this.node), this.options)
            .then(() => {
    Severity: Major
    Found in modules/cms/client/js/manager/gallery.ui.js - About 2 hrs to fix

      Function buildUI has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          buildUI() {
        let self = this;
        return template
            .render('cms/cms/gallery', this.options || {})
            .then(nodes => {
      Severity: Major
      Found in modules/cms/client/js/manager/gallery.ui.js - About 2 hrs to fix

        Function drawTaxonomy has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            drawTaxonomy() {


        if (!this.options.media) return;
        Severity: Minor
        Found in modules/cms/client/js/manager/gallery.ui.js - About 1 hr to fix

          Function drawTaxonomy has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              drawTaxonomy() {


        if (!this.options.media) return;
          Severity: Minor
          Found in modules/cms/client/js/manager/gallery.ui.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              remove() {
        return new Promise(resolve => {
            let self = this,
                handler = () => {
                    self.node.removeEventListener('transitionend', handler, false);
          Severity: Major
          Found in modules/cms/client/js/manager/gallery.ui.js and 1 other location - About 3 hrs to fix
          modules/cms/client/js/manager/picker.ui.js on lines 125..138

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 113.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              toggle(event) {

        event.preventDefault();
        event.stopPropagation();
          Severity: Major
          Found in modules/cms/client/js/manager/gallery.ui.js and 1 other location - About 3 hrs to fix
          modules/cms/client/js/manager/structure.ui.js on lines 793..805

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              constructor(options) {
        super();
        this.options = options;
        this._locked = null;
        let self = this;
          Severity: Major
          Found in modules/cms/client/js/manager/gallery.ui.js and 1 other location - About 2 hrs to fix
          modules/cms/client/js/manager/picker.ui.js on lines 34..46

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 83.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              keyup() {
        let self = this;
        if (this._locked) {
            clearTimeout(this._locked);
        }
          Severity: Major
          Found in modules/cms/client/js/manager/gallery.ui.js and 1 other location - About 1 hr to fix
          modules/cms/client/js/manager/picker.ui.js on lines 92..103

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 72.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                          lackey.bind('[data-lky-hook=table-paging]', 'click', (event, hook) => {
                    event.preventDefault();
                    var thisPage = hook.dataset.page;
                    self.query(thisPage);
                }, nodes[0]);
          Severity: Major
          Found in modules/cms/client/js/manager/gallery.ui.js and 1 other location - About 1 hr to fix
          modules/cms/client/js/manager/taxonomy.picker.ui.js on lines 86..90

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status