Sign upLogin

getlackey/lackey-cms

View on GitHub
Star
modules/cms/client/js/manager/index.js

Summary

Maintainability
F
3 days
Test Coverage

File index.js has 448 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* eslint no-cond-assign:0, no-new:0 no-param-reassign:0 */
/* jslint browser:true, node:true, esnext:true */
'use strict';
/*
    Copyright 2016 Enigma Marketing Services Limited
Severity: Minor
Found in modules/cms/client/js/manager/index.js - About 6 hrs to fix

    Function setupUI has 90 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Manager.prototype.setupUI = function () {

    let self = this,
        settingsButton = lackey.hook('header.settings');
    Severity: Major
    Found in modules/cms/client/js/manager/index.js - About 3 hrs to fix

      Function preview has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Manager.prototype.preview = function (variant, language) {
    let self = this;
    this
        .current
        .then(def => self.repository.get('content', def.id))
      Severity: Minor
      Found in modules/cms/client/js/manager/index.js - About 1 hr to fix

        Function Manager has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function Manager() {

    let self = this,
        overlay = lackey
        .hook('settings.overlay');
        Severity: Minor
        Found in modules/cms/client/js/manager/index.js - About 1 hr to fix

          Function showTab has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          Manager.prototype.showTab = function (tab, callback) {
    lackey.hook('header.settings').setAttribute('disabled', 'disabled');

    let self = this,
        structureController,
          Severity: Minor
          Found in modules/cms/client/js/manager/index.js - About 1 hr to fix

            Function _loadCurrent has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            Manager.prototype._loadCurrent = function () {

    let
        loc = top.location.pathname,
        self = this;
            Severity: Minor
            Found in modules/cms/client/js/manager/index.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            Manager.prototype.get = function (contentId, path, variant, schema) {

    return this.repository
        .get('content', contentId)
        .then(content => {
            Severity: Major
            Found in modules/cms/client/js/manager/index.js and 1 other location - About 3 hrs to fix
            modules/cms/client/js/manager/index.js on lines 203..214

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 111.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            Manager.prototype.getProperty = function (contentId, path, variant, schema) {

    return this.repository
        .get('content', contentId)
        .then(content => {
            Severity: Major
            Found in modules/cms/client/js/manager/index.js and 1 other location - About 3 hrs to fix
            modules/cms/client/js/manager/index.js on lines 166..177

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 111.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            Manager.prototype.insertAfter = function (contentId, path, variant, value) {
    return this
        .update('content', contentId, function (content) {
            treeParser.insertAfter(content.layout, path, value, variant || '*', null, locale !== defaultLocale ? locale : '*');
        });
            Severity: Major
            Found in modules/cms/client/js/manager/index.js and 2 other locations - About 2 hrs to fix
            modules/cms/client/js/manager/index.js on lines 187..192
            modules/cms/client/js/manager/index.js on lines 224..229

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 81.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            Manager.prototype.set = function (contentId, path, variant, value) {
    return this
        .update('content', contentId, function (content) {
            treeParser.set(content.layout, path, value, variant || '*', null, locale !== defaultLocale ? locale : '*');
        });
            Severity: Major
            Found in modules/cms/client/js/manager/index.js and 2 other locations - About 2 hrs to fix
            modules/cms/client/js/manager/index.js on lines 224..229
            modules/cms/client/js/manager/index.js on lines 240..245

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 81.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            Manager.prototype.setProperty = function (contentId, path, variant, value) {
    return this
        .update('content', contentId, function (content) {
            treeParser.set(content.props, path, value, variant || '*', null, locale !== defaultLocale ? locale : '*');
        });
            Severity: Major
            Found in modules/cms/client/js/manager/index.js and 2 other locations - About 2 hrs to fix
            modules/cms/client/js/manager/index.js on lines 187..192
            modules/cms/client/js/manager/index.js on lines 240..245

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 81.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status