Sign upLogin

getlackey/lackey-cms

View on GitHub
Star
modules/cms/server/lib/dust/media.js

Summary

Maintainability
F
1 wk
Test Coverage

Function print has a Cognitive Complexity of 65 (exceeds 5 allowed). Consider refactoring.
Open

function print(chunk, data, type, editMode, dust, log, config) {
  let source;

  SCli.debug('lackey-cms/modules/cms/server/lib/dust/media', 'Print', JSON.stringify(data, null, 4));
Severity: Minor
Found in modules/cms/server/lib/dust/media.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has 118 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = (dust, config) => {

  dust.filters.media = function (value) {
    var returnString = '';
    if (value.mime === 'video/youtube') {
Severity: Major
Found in modules/cms/server/lib/dust/media.js - About 4 hrs to fix

    Function exports has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = (dust, config) => {

  dust.filters.media = function (value) {
    var returnString = '';
    if (value.mime === 'video/youtube') {
    Severity: Minor
    Found in modules/cms/server/lib/dust/media.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function print has 100 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function print(chunk, data, type, editMode, dust, log, config) {
  let source;

  SCli.debug('lackey-cms/modules/cms/server/lib/dust/media', 'Print', JSON.stringify(data, null, 4));
    Severity: Major
    Found in modules/cms/server/lib/dust/media.js - About 4 hrs to fix

      Function media has 64 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        dust.helpers.media = function (chunk, context, bodies, params) {

    let editMode = params.editMode,
      content = params.content,
      id = content ? content.id + '' : '',
      Severity: Major
      Found in modules/cms/server/lib/dust/media.js - About 2 hrs to fix

        Function media has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          dust.filters.media = function (value) {
    var returnString = '';
    if (value.mime === 'video/youtube') {
        returnString += '<iframe type="text/html" src="https://www.youtube.com/embed/' + isYoutube(value.source) + '" frameborder="0"></iframe>';
      } else if (value.mime === 'video/vimeo') {
        Severity: Minor
        Found in modules/cms/server/lib/dust/media.js - About 2 hrs to fix

          Function print has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function print(chunk, data, type, editMode, dust, log, config) {
          Severity: Major
          Found in modules/cms/server/lib/dust/media.js - About 50 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              dust.filters.media = function (value) {
    var returnString = '';
    if (value.mime === 'video/youtube') {
        returnString += '<iframe type="text/html" src="https://www.youtube.com/embed/' + isYoutube(value.source) + '" frameborder="0"></iframe>';
      } else if (value.mime === 'video/vimeo') {
            Severity: Major
            Found in modules/cms/server/lib/dust/media.js and 1 other location - About 3 days to fix
            modules/core/shared/dust/media.js on lines 8..63

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 648.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    Object.keys(data.attrs).forEach((key) => {
          chunk.write(' ' + key + '="' + data.attrs[key].replace(/"/g, '&quot;') + '"');
        });
            Severity: Major
            Found in modules/cms/server/lib/dust/media.js and 1 other location - About 1 hr to fix
            modules/cms/server/lib/dust/media.js on lines 128..130

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 73.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                      Object.keys(data.attrs).forEach((key) => {
            chunk.write(' ' + key + '="' + data.attrs[key].replace(/"/g, '&quot;') + '"');
          });
            Severity: Major
            Found in modules/cms/server/lib/dust/media.js and 1 other location - About 1 hr to fix
            modules/cms/server/lib/dust/media.js on lines 96..98

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 73.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    return SUtils.cmsMod('core')
          .model('media')
          .then((Media) => {
            return Media.findById(data.id);
          })
            Severity: Minor
            Found in modules/cms/server/lib/dust/media.js and 1 other location - About 50 mins to fix
            modules/cms/server/lib/dust/acl.js on lines 29..34

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status