getlackey/lackey-cms

View on GitHub
modules/core/server/models/content/index.js

Summary

Maintainability
F
4 days
Test Coverage

Function exports has 377 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    .then((Taggable, User, Taxonomy, TaxonomyType, Template, knexSchema, QueryBuilder, configuration) => {

        SCli.debug(__MODULE_NAME, 'READY');

        class ContentModel extends Model {
Severity: Major
Found in modules/core/server/models/content/index.js - About 1 day to fix

    Function exports has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
    Open

        .then((Taggable, User, Taxonomy, TaxonomyType, Template, knexSchema, QueryBuilder, configuration) => {
    
            SCli.debug(__MODULE_NAME, 'READY');
    
            class ContentModel extends Model {
    Severity: Minor
    Found in modules/core/server/models/content/index.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File index.js has 399 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* eslint no-underscore-dangle:0 */
    /* jslint node:true, esnext:true */
    /* globals LACKEY_PATH */
    'use strict';
    
    
    Severity: Minor
    Found in modules/core/server/models/content/index.js - About 5 hrs to fix

      Function jsonSchema has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  static get jsonSchema() {
                      return {
                          type: 'object',
                          required: ['type', 'route'],
                          properties: {
      Severity: Minor
      Found in modules/core/server/models/content/index.js - About 1 hr to fix

        Function toYAML has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    toYAML() {
                        let self = this;
                        return Content.serializer
                            .serialize(self.toJSON())
                            .then((content) => {
        Severity: Minor
        Found in modules/core/server/models/content/index.js - About 1 hr to fix

          Function _preSave has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                      _preSave() {
          
                          let self = this,
                              promise = super._preSave();
          
          
          Severity: Minor
          Found in modules/core/server/models/content/index.js - About 1 hr to fix

            Function query has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                        static query (query, populate, options) {
                            if (options.taxonomies) {
                                return Promise.all(options.taxonomies.map((taxonomy) => {
                                    return TaxonomyType.findOneBy('name', taxonomy.type);
                                })).then((responses) => {
            Severity: Minor
            Found in modules/core/server/models/content/index.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  return (Array.isArray(object) ? object : Object.keys(object).map(key => key === 'type' ? '' : object[key]))
                                      .map(item => self.getPlainText(item))
              Severity: Minor
              Found in modules/core/server/models/content/index.js and 1 other location - About 55 mins to fix
              modules/core/server/models/content/upgrade.js on lines 34..35

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 54.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status