Sign upLogin

getlackey/lackey-cms

View on GitHub
Star
modules/core/server/models/content/upgrade.js

Summary

Maintainability
F
3 days
Test Coverage

Function exports has 161 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = () => new Promise((resolve, reject) => {
        atomus()
            .html('<html></html>')
            .ready(function (errors, window) {
                try {
Severity: Major
Found in modules/core/server/models/content/upgrade.js - About 6 hrs to fix

    Function exports has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = () => new Promise((resolve, reject) => {
        atomus()
            .html('<html></html>')
            .ready(function (errors, window) {
                try {
    Severity: Minor
    Found in modules/core/server/models/content/upgrade.js - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File upgrade.js has 273 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* jslint node:true, esnext:true */
/* globals LACKEY_PATH, window */
'use strict';

const
    Severity: Minor
    Found in modules/core/server/models/content/upgrade.js - About 2 hrs to fix

      Function crawlBack has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              function crawlBack(data) {
            if (data) {
                if (data.type === 'doc') {
                    return Promise.resolve(toMarkdown(parseFrom(window.LackeySchema, data, 'json')).replace(/\s\s\r\n/g, ' \\n'));
                }
      Severity: Minor
      Found in modules/core/server/models/content/upgrade.js - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (data.type === 'Fields' || data.type === 'Variants') {
                Object.keys(data)
                    .forEach(key => {
                        if (['type'].indexOf(key) === -1) {
                            let content = data[key];
        Severity: Major
        Found in modules/core/server/models/content/upgrade.js and 1 other location - About 4 hrs to fix
        modules/core/server/models/content/serializer.js on lines 144..153

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 126.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            ['fields', 'variants', 'items']
            .forEach(group => {
                if (data[group]) {
                    Object.keys(data[group])
                        .forEach(key => {
        Severity: Major
        Found in modules/core/server/models/content/upgrade.js and 1 other location - About 4 hrs to fix
        modules/core/server/models/content/serializer.js on lines 133..142

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 120.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                str += (Array.isArray(object) ? object : Object.keys(object).map(key => key === 'type' ? '' : object[key]))
            .map(item => getPlainText(item))
        Severity: Minor
        Found in modules/core/server/models/content/upgrade.js and 1 other location - About 55 mins to fix
        modules/core/server/models/content/index.js on lines 280..281

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status