Sign upLogin

getlackey/lackey-cms

View on GitHub
Star
modules/users/server/controllers/account.js

Summary

Maintainability
F
4 days
Test Coverage

Function exports has 224 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    .then((User, Session) => {
        return {
            index: (req, res) => {

                let data = {};
Severity: Major
Found in modules/users/server/controllers/account.js - About 1 day to fix

    Function removeIdentity has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                removeIdentity: (req, res) => {
                req.admin.getIdentities('email')
                    .then((identities) => {
                        let confCount = 0,
                            confirmed = false;
    Severity: Minor
    Found in modules/users/server/controllers/account.js - About 1 hr to fix

      Function sendConfirmationEmail has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  sendConfirmationEmail: (req, res) => {
                let lib, config;
                SCli.debug(__MODULE_NAME, 'Respond');
                configuration()
                    .then((cfg) => {
      Severity: Minor
      Found in modules/users/server/controllers/account.js - About 1 hr to fix

        Function forgot has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    forgot: (req, res) => {
                let userId;
                if (!req.body.username.length) { //TODO improve
                    throw(new Error('Email not found'));
                }
        Severity: Minor
        Found in modules/users/server/controllers/account.js - About 1 hr to fix

          Function exports has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              .then((User, Session) => {
        return {
            index: (req, res) => {

                let data = {};
          Severity: Minor
          Found in modules/users/server/controllers/account.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                          req.admin.setIdentity('email', req.body.email, null, null, null, false, true)
                    .then(() => {
                        let data = {};
                        req.admin
                            .getIdentities('email')
          Severity: Major
          Found in modules/users/server/controllers/account.js and 1 other location - About 4 hrs to fix
          modules/users/server/controllers/account.js on lines 243..259

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 128.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                                      req.admin.removeIdentity('email', req.body.email)
                                .then(() => {
                                    let data = {};
                                    req.admin
                                        .getIdentities('email')
          Severity: Major
          Found in modules/users/server/controllers/account.js and 1 other location - About 4 hrs to fix
          modules/users/server/controllers/account.js on lines 208..224

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 128.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              .then(() => {
                        req.login(user, function (error) {
                            if (error) {
                                /* istanbul ignore next */
                                res.status(400).error(error);
          Severity: Major
          Found in modules/users/server/controllers/account.js and 1 other location - About 3 hrs to fix
          modules/users/server/controllers/account.js on lines 174..184

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 114.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                                  user.save().then(() => {
                            req.login(user, function (error) {
                                if (error) {
                                    /* istanbul ignore next */
                                    res.status(400).error(error);
          Severity: Major
          Found in modules/users/server/controllers/account.js and 1 other location - About 3 hrs to fix
          modules/users/server/controllers/account.js on lines 151..161

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 114.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          User.findById(req.forgotPasswordUid)
                    .then((usr) => {
                        user = usr;
                        return user.validateToken(req.forgotPasswordToken, 'password');
                    })
          Severity: Major
          Found in modules/users/server/controllers/account.js and 1 other location - About 1 hr to fix
          modules/cms/server/controllers/user.js on lines 279..291

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          User.findById(req.forgotPasswordUid)
                    .then((usr) => {
                        user = usr;
                        return user.invalidatePasswordToken(req.forgotPasswordToken, 'password');
                    })
          Severity: Major
          Found in modules/users/server/controllers/account.js and 1 other location - About 1 hr to fix
          modules/users/server/controllers/account.js on lines 130..142

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 55.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

          module.exports = SUtils.waitForAs(__MODULE_NAME,
        SUtils.cmsMod('core').model('user'),
        SUtils.cmsMod('core').model('session')
    )
    .then((User, Session) => {
          Severity: Minor
          Found in modules/users/server/controllers/account.js and 2 other locations - About 40 mins to fix
          modules/core/server/models/taggable/index.js on lines 30..194
          modules/core/server/models/taxonomy-type/index.js on lines 30..98

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status