Sign upLogin

gfw-api/fw-contextual-layers

View on GitHub
Star
app/src/routes/api/v1/layer.router.js

Summary

Maintainability
D
2 days
Test Coverage
F
16%

Function deleteLayer has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    static async deleteLayer(ctx) {
        const { layerId } = ctx.params;
        logger.info(`Delete layer with id ${layerId}`);
        let layer = null;
        try {
Severity: Minor
Found in app/src/routes/api/v1/layer.router.js - About 1 hr to fix

    Function patchLayer has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        static async patchLayer(ctx) {
        logger.info('Patch layer by id');
        const { layerId } = ctx.params;
        const { body } = ctx.request;
        let layer = null;
    Severity: Minor
    Found in app/src/routes/api/v1/layer.router.js - About 1 hr to fix

      Function createTeamLayer has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          static async createTeamLayer(ctx) {
        logger.info('Create team layer');
        const owner = { type: LayerService.type.TEAM, id: ctx.params.teamId };
        let team = null;
        try {
      Severity: Minor
      Found in app/src/routes/api/v1/layer.router.js - About 1 hr to fix

        Function getAll has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            static async getAll(ctx) {
        logger.info('Get all layers');
        const userId = ctx.request.body.user.id;
        const enabled = typeof ctx.request.query.enabled !== 'undefined'
            ? { enabled: ctx.request.query.enabled }
        Severity: Minor
        Found in app/src/routes/api/v1/layer.router.js - About 1 hr to fix

          Function deleteLayer has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              static async deleteLayer(ctx) {
        const { layerId } = ctx.params;
        logger.info(`Delete layer with id ${layerId}`);
        let layer = null;
        try {
          Severity: Minor
          Found in app/src/routes/api/v1/layer.router.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function createTeamLayer has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              static async createTeamLayer(ctx) {
        logger.info('Create team layer');
        const owner = { type: LayerService.type.TEAM, id: ctx.params.teamId };
        let team = null;
        try {
          Severity: Minor
          Found in app/src/routes/api/v1/layer.router.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function patchLayer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              static async patchLayer(ctx) {
        logger.info('Patch layer by id');
        const { layerId } = ctx.params;
        const { body } = ctx.request;
        let layer = null;
          Severity: Minor
          Found in app/src/routes/api/v1/layer.router.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (layer.owner.type === LayerService.type.TEAM) {
            try {
                team = await TeamService.getTeam(layer.owner.id);
            } catch (e) {
                logger.error(e);
          Severity: Major
          Found in app/src/routes/api/v1/layer.router.js and 1 other location - About 2 hrs to fix
          app/src/routes/api/v1/layer.router.js on lines 113..120

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 89.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (layer.owner.type === LayerService.type.TEAM) {
            try {
                team = await TeamService.getTeam(layer.owner.id);
            } catch (e) {
                logger.error(e);
          Severity: Major
          Found in app/src/routes/api/v1/layer.router.js and 1 other location - About 2 hrs to fix
          app/src/routes/api/v1/layer.router.js on lines 146..153

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 89.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  try {
            layer = await LayerModel.findOne({ _id: layerId });
            if (!layer) ctx.throw(404, 'Layer not found');
        } catch (e) {
            logger.error(e);
          Severity: Major
          Found in app/src/routes/api/v1/layer.router.js and 1 other location - About 2 hrs to fix
          app/src/routes/api/v1/layer.router.js on lines 105..111

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 78.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  try {
            layer = await LayerModel.findOne({ _id: layerId });
            if (!layer) ctx.throw(404, 'Layer not found');
        } catch (e) {
            logger.error(e);
          Severity: Major
          Found in app/src/routes/api/v1/layer.router.js and 1 other location - About 2 hrs to fix
          app/src/routes/api/v1/layer.router.js on lines 138..144

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 78.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  try {
            layer = await LayerService.create(ctx.request.body, owner);
        } catch (e) {
            logger.error(e);
            ctx.throw(500, 'Layer creation Failed.');
          Severity: Major
          Found in app/src/routes/api/v1/layer.router.js and 1 other location - About 1 hr to fix
          app/src/routes/api/v1/layer.router.js on lines 81..86

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      try {
                layer = await LayerService.create(ctx.request.body, owner);
            } catch (e) {
                logger.error(e);
                ctx.throw(500, 'Layer creation Failed.');
          Severity: Major
          Found in app/src/routes/api/v1/layer.router.js and 1 other location - About 1 hr to fix
          app/src/routes/api/v1/layer.router.js on lines 59..64

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status