Sign upLogin

gfw-api/gfw-forms-api

View on GitHub
Star
app/src/routes/api/v1/questionnaireAnswer.router.js

Summary

Maintainability
D
2 days
Test Coverage
F
18%

Function save has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    static* save() {
        logger.info('Saving questionnaire');
        logger.debug(this.request.body);

        const answer = {
Severity: Minor
Found in app/src/routes/api/v1/questionnaireAnswer.router.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function save has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    static* save() {
        logger.info('Saving questionnaire');
        logger.debug(this.request.body);

        const answer = {
Severity: Minor
Found in app/src/routes/api/v1/questionnaireAnswer.router.js - About 1 hr to fix

    Function loggedUserToState has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    function* loggedUserToState(next) {
    if (this.query && this.query.loggedUser) {
        this.state.loggedUser = JSON.parse(this.query.loggedUser);
        delete this.query.loggedUser;
    } else if (this.request.body && (this.request.body.loggedUser || (this.request.body.fields && this.request.body.fields.loggedUser))) {
    Severity: Minor
    Found in app/src/routes/api/v1/questionnaireAnswer.router.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                            if (question.type === 'blob') {
                            // upload file
                            response = yield s3Service.uploadFile(response.path, response.name);
                        }
    Severity: Major
    Found in app/src/routes/api/v1/questionnaireAnswer.router.js - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      function* loggedUserToState(next) {
    if (this.query && this.query.loggedUser) {
        this.state.loggedUser = JSON.parse(this.query.loggedUser);
        delete this.query.loggedUser;
    } else if (this.request.body && (this.request.body.loggedUser || (this.request.body.fields && this.request.body.fields.loggedUser))) {
      Severity: Major
      Found in app/src/routes/api/v1/questionnaireAnswer.router.js and 1 other location - About 1 day to fix
      app/src/routes/api/v1/answers.router.js on lines 176..193

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 329.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

              if (!result || !result.result || result.result.ok === 0) {
            this.throw(404, 'Answer not found');
            return;
        }
      Severity: Major
      Found in app/src/routes/api/v1/questionnaireAnswer.router.js and 3 other locations - About 40 mins to fix
      app/src/routes/api/v1/answers.router.js on lines 166..169
      app/src/routes/api/v1/questionnaire.router.js on lines 45..48
      app/src/routes/api/v1/reports.router.js on lines 300..303

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status