Sign upLogin

gfw-api/gfw-geostore-api

View on GitHub
Star
app/src/routes/api/v2/geoStore.router.js

Summary

Maintainability
F
1 wk
Test Coverage
D
65%

Function use has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    static async use(ctx) {
        logger.info('Obtaining use data with name %s and id %s', ctx.params.name, ctx.params.id);
        const thresh = ctx.query.simplify ? JSON.parse(ctx.query.simplify.toLowerCase()) : null;
        if (thresh && typeof thresh === Boolean && thresh !== true) {
            ctx.throw(404, 'Bad syntax for simplify. Must be "true".');
Severity: Minor
Found in app/src/routes/api/v2/geoStore.router.js - About 1 hr to fix

    Function createGeoStore has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        static async createGeoStore(ctx) {
        logger.info('Saving GeoStore');
        try {
            const data = {
                provider: ctx.request.body.provider,
    Severity: Minor
    Found in app/src/routes/api/v2/geoStore.router.js - About 1 hr to fix

      Function getArea has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          static async getArea(ctx) {
        logger.info('Retrieving Polygon Area');
        try {
            const data = {
                provider: ctx.request.body.provider,
      Severity: Minor
      Found in app/src/routes/api/v2/geoStore.router.js - About 1 hr to fix

        Function getArea has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            static async getArea(ctx) {
        logger.info('Retrieving Polygon Area');
        try {
            const data = {
                provider: ctx.request.body.provider,
        Severity: Minor
        Found in app/src/routes/api/v2/geoStore.router.js - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function createGeoStore has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            static async createGeoStore(ctx) {
        logger.info('Saving GeoStore');
        try {
            const data = {
                provider: ctx.request.body.provider,
        Severity: Minor
        Found in app/src/routes/api/v2/geoStore.router.js - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getSubnational has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            static async getSubnational(ctx) {
        logger.info('Obtaining subnational data geojson (GADM v3.6)');
        const thresh = ctx.query.simplify ? JSON.parse(ctx.query.simplify.toLowerCase()) : null;

        if (thresh && typeof thresh === Number && (thresh > 1 || thresh <= 0)) {
        Severity: Minor
        Found in app/src/routes/api/v2/geoStore.router.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getNational has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            static async getNational(ctx) {
        logger.info('Obtaining national data geojson (GADM v3.6)');
        const thresh = ctx.query.simplify ? JSON.parse(ctx.query.simplify.toLowerCase()) : null;

        if (thresh && typeof thresh === Number && (thresh > 1 || thresh <= 0)) {
        Severity: Minor
        Found in app/src/routes/api/v2/geoStore.router.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function use has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            static async use(ctx) {
        logger.info('Obtaining use data with name %s and id %s', ctx.params.name, ctx.params.id);
        const thresh = ctx.query.simplify ? JSON.parse(ctx.query.simplify.toLowerCase()) : null;
        if (thresh && typeof thresh === Boolean && thresh !== true) {
            ctx.throw(404, 'Bad syntax for simplify. Must be "true".');
        Severity: Minor
        Found in app/src/routes/api/v2/geoStore.router.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getRegional has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            static async getRegional(ctx) {
        logger.info('Obtaining Admin2 data geojson (GADM v3.6)');
        const thresh = ctx.query.simplify ? JSON.parse(ctx.query.simplify.toLowerCase()) : null;

        if (thresh && typeof thresh === Number && (thresh > 1 || thresh <= 0)) {
        Severity: Minor
        Found in app/src/routes/api/v2/geoStore.router.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            static async getArea(ctx) {
        logger.info('Retrieving Polygon Area');
        try {
            const data = {
                provider: ctx.request.body.provider,
        Severity: Major
        Found in app/src/routes/api/v2/geoStore.router.js and 2 other locations - About 2 days to fix
        app/src/routes/api/v1/geoStore.router.js on lines 104..131
        app/src/routes/api/v2/geoStore.router.js on lines 78..106

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 370.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            static async createGeoStore(ctx) {
        logger.info('Saving GeoStore');
        try {
            const data = {
                provider: ctx.request.body.provider,
        Severity: Major
        Found in app/src/routes/api/v2/geoStore.router.js and 2 other locations - About 2 days to fix
        app/src/routes/api/v1/geoStore.router.js on lines 104..131
        app/src/routes/api/v2/geoStore.router.js on lines 108..135

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 370.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            static async getGeoStoreById(ctx) {
        ctx.assert(ctx.params.hash, 400, 'Hash param not found');
        logger.info('[GeoStoreRouterV2 - getGeoStoreById] Getting geostore by hash %s', ctx.params.hash);

        let geoStore = await GeoStoreServiceV2.getGeostoreById(ctx.params.hash);
        Severity: Major
        Found in app/src/routes/api/v2/geoStore.router.js and 1 other location - About 1 day to fix
        app/src/routes/api/v1/geoStore.router.js on lines 23..43

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 239.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            static async wdpa(ctx) {
        logger.info('Obtaining wpda data with id %s', ctx.params.id);
        const data = await CartoServiceV2.getWdpa(ctx.params.id);
        if (!data) {
            ctx.throw(404, 'Wdpa not found');
        Severity: Major
        Found in app/src/routes/api/v2/geoStore.router.js and 1 other location - About 2 hrs to fix
        app/src/routes/api/v1/geoStore.router.js on lines 206..214

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 94.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                if (thresh && typeof thresh === Number && (thresh > 1 || thresh <= 0)) {
            ctx.throw(404, 'Bad threshold for simplify. Must be in range 0-1.');
        } else if (thresh && typeof thresh === Boolean && thresh !== true) {
            ctx.throw(404, 'Bad syntax for simplify. Must be "true".');
        }
        Severity: Major
        Found in app/src/routes/api/v2/geoStore.router.js and 2 other locations - About 2 hrs to fix
        app/src/routes/api/v2/geoStore.router.js on lines 141..145
        app/src/routes/api/v2/geoStore.router.js on lines 182..186

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 83.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                if (thresh && typeof thresh === Number && (thresh > 1 || thresh <= 0)) {
            ctx.throw(404, 'Bad threshold for simplify. Must be in range 0-1.');
        } else if (thresh && typeof thresh === Boolean && thresh !== true) {
            ctx.throw(404, 'Bad syntax for simplify. Must be "true".');
        }
        Severity: Major
        Found in app/src/routes/api/v2/geoStore.router.js and 2 other locations - About 2 hrs to fix
        app/src/routes/api/v2/geoStore.router.js on lines 166..170
        app/src/routes/api/v2/geoStore.router.js on lines 182..186

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 83.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                if (thresh && typeof thresh === Number && (thresh > 1 || thresh <= 0)) {
            ctx.throw(404, 'Bad threshold for simplify. Must be in range 0-1.');
        } else if (thresh && typeof thresh === Boolean && thresh !== true) {
            ctx.throw(404, 'Bad syntax for simplify. Must be "true".');
        }
        Severity: Major
        Found in app/src/routes/api/v2/geoStore.router.js and 2 other locations - About 2 hrs to fix
        app/src/routes/api/v2/geoStore.router.js on lines 141..145
        app/src/routes/api/v2/geoStore.router.js on lines 166..170

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 83.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            static async getNationalList(ctx) {
        logger.info('Obtaining national list (GADM v3.6)');
        const data = await CartoServiceV2.getNationalList();
        if (!data) {
            ctx.throw(404, 'Empty List');
        Severity: Major
        Found in app/src/routes/api/v2/geoStore.router.js and 1 other location - About 2 hrs to fix
        app/src/routes/api/v1/geoStore.router.js on lines 142..149

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 76.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                const parsedData = {
            geostores: slicedGeoStores,
            geostoresFound: geoStores.map((el) => el.hash),
            found: foundGeoStores,
            returned: slicedGeoStores.length
        Severity: Minor
        Found in app/src/routes/api/v2/geoStore.router.js and 1 other location - About 40 mins to fix
        app/src/routes/api/v1/geoStore.router.js on lines 65..71

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status