Sign upLogin

gfw-api/gfw-geostore-api

View on GitHub
Star
app/src/services/cartoDBServiceV2.js

Summary

Maintainability
F
4 days
Test Coverage
C
78%

File cartoDBServiceV2.js has 271 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const logger = require('logger');
const config = require('config');
const CartoDB = require('cartodb');
const Mustache = require('mustache');
const GeoStoreServiceV2 = require('services/geoStoreServiceV2');
Severity: Minor
Found in app/src/services/cartoDBServiceV2.js - About 2 hrs to fix

    Function getRegional has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        async getRegional(iso, id1, id2, thresh) {
        logger.debug('Obtaining admin2 of iso %s, id1 and id2', iso, id1, id2);
        const params = {
            id2: `${iso.toUpperCase()}.${parseInt(id1, 10)}.${parseInt(id2, 10)}_1`
        };
    Severity: Minor
    Found in app/src/services/cartoDBServiceV2.js - About 1 hr to fix

      Function getSubnational has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          async getSubnational(iso, id1, thresh) {
        logger.debug('Obtaining subnational of iso %s and id1', iso, id1);
        const params = {
            id1: `${iso.toUpperCase()}.${parseInt(id1, 10)}_1`
        };
      Severity: Minor
      Found in app/src/services/cartoDBServiceV2.js - About 1 hr to fix

        Function getNational has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            async getNational(iso, thresh) {
        logger.info(`[CartoDBServiceV2 - getNational] Requesting ISO ${iso} from carto`);
        const params = {
            iso: iso.toUpperCase()
        };
        Severity: Minor
        Found in app/src/services/cartoDBServiceV2.js - About 1 hr to fix

          Function getUse has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              async getUse(use, id, thresh) {
        logger.debug('Obtaining use with id %s', id);
        const params = {
            use,
            id: parseInt(id, 10)
          Severity: Minor
          Found in app/src/services/cartoDBServiceV2.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                async getNationalList() {
        logger.debug('Request national list names from carto');
        const countryList = await GeoStoreServiceV2.getNationalList();
        const isoValuesMap = countryList.map((el) => el.info.iso);
        let isoValues = '';
            Severity: Major
            Found in app/src/services/cartoDBServiceV2.js and 1 other location - About 1 day to fix
            app/src/services/cartoDBService.js on lines 91..113

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 342.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                async getWdpa(wdpaid) {
        logger.debug('Obtaining wpda of id %s', wdpaid);

        const params = {
            wdpaid: parseInt(wdpaid, 10)
            Severity: Major
            Found in app/src/services/cartoDBServiceV2.js and 1 other location - About 1 day to fix
            app/src/services/cartoDBService.js on lines 214..242

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 243.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                client.execute(sql, params).done((data) => {
        resolve(data);
    }).error((err) => {
        reject(err);
    });
            Severity: Minor
            Found in app/src/services/cartoDBServiceV2.js and 1 other location - About 55 mins to fix
            app/src/services/cartoDBService.js on lines 44..48

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status