Sign upLogin

gfw-api/gfw-subscription-api

View on GitHub
Star
app/src/migrate/migrate.js

Summary

Maintainability
C
1 day
Test Coverage
F
0%

Function transformAndSaveData has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

const transformAndSaveData = async (data) => {
    logger.info('Saving data');
    if (data) {
        for (let i = 0, { length } = data; i < length; i++) {
            if (data[i].confirmed) {
Severity: Minor
Found in app/src/migrate/migrate.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function transformAndSaveData has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const transformAndSaveData = async (data) => {
    logger.info('Saving data');
    if (data) {
        for (let i = 0, { length } = data; i < length; i++) {
            if (data[i].confirmed) {
Severity: Major
Found in app/src/migrate/migrate.js - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

                if (data[i].confirmed) {
                //  logger.debug('Saving data', data[i]);
                let userId = null;
                if (data[i].user_id) {
                    userId = await obtainNewUserId(data[i].user_id);
    Severity: Critical
    Found in app/src/migrate/migrate.js - About 2 hrs to fix

      Consider simplifying this complex logical expression.
      Open

                      if (
                    !data[i].params.iso
                    && !data[i].params.id1
                    && !data[i].params.wdpaid
                    && !data[i].params.use
      Severity: Critical
      Found in app/src/migrate/migrate.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                            if (!geostore.body.data) {
                        logger.error('Is not correct');
                        logger.error(data[i].params.geom);
                        // eslint-disable-next-line no-continue
                        continue;
        Severity: Major
        Found in app/src/migrate/migrate.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              if (!data[i].params.geom) {
                        // eslint-disable-next-line no-continue
                        continue;
                    }
          Severity: Major
          Found in app/src/migrate/migrate.js - About 45 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            const mongoUri = process.env.MONGO_URI || `mongodb://${config.get('mongodb.host')}:${config.get('mongodb.port')}/${config.get('mongodb.database')}`;
            Severity: Major
            Found in app/src/migrate/migrate.js and 1 other location - About 1 hr to fix
            app/src/app.js on lines 17..17

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 60.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status