ghostsquad/swarmci

View on GitHub

Showing 3 of 6 total issues

Function __init__ has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, image, remove=True, url=':4000', env=None, docker=None, cn=None, **kwargs):
Severity: Major
Found in swarmci/runners.py - About 50 mins to fix

Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, image, host_config, docker, name=None, env=None, remove=True):
Severity: Minor
Found in swarmci/docker.py - About 45 mins to fix

Function build_tasks_hierarchy has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def build_tasks_hierarchy(swarmci_config, task_factory):
    stages_from_yaml = swarmci_config.pop('stages', None)
    if stages_from_yaml is None:
        raise SwarmCIError('Did not find "stages" key in the .swarmci file.')
    elif type(stages_from_yaml) is not list:
Severity: Minor
Found in swarmci/__init__.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language