giansalex/greenter

View on GitHub

Showing 65 of 97 total issues

Method processResponse has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function processResponse($status): StatusResult
    {
        $originCode = $status->statusCode;
        $code = (int)$originCode;

Severity: Minor
Found in packages/ws/src/Ws/Services/ExtService.php - About 1 hr to fix

    Method getTemplate has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getTemplate(DocumentInterface $document): ?string
        {
            $className = get_class($document);
            switch ($className) {
                case Invoice::class:
    Severity: Minor
    Found in packages/report/src/Report/Resolver/DefaultTemplateResolver.php - About 1 hr to fix

      Method load has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function load(ClassMetadata $metadata)
          {
              $metadata->addPropertyConstraints('tipoDoc', [
                  new Assert\NotBlank(),
                  new Assert\Length(['max' => 2]),
      Severity: Minor
      Found in packages/validator/src/Validator/Loader/RetentionDetailLoader.php - About 1 hr to fix

        Function loadTotals has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            private function loadTotals(Note $inv, DOMNode $node = null)
            {
                if (empty($node)) {
                    return;
                }
        Severity: Minor
        Found in packages/xml-parser/src/Xml/Parser/NoteParser.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getStatusResult has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private function getStatusResult(string $method, string $resultName, string $ruc, string $tipo, string $serie, int $numero)
        Severity: Minor
        Found in packages/ws/src/Ws/Services/ConsultCdrService.php - About 45 mins to fix

          Function getTemplate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getTemplate(DocumentInterface $document): ?string
              {
                  $className = get_class($document);
                  switch ($className) {
                      case Invoice::class:
          Severity: Minor
          Found in packages/report/src/Report/Resolver/DefaultTemplateResolver.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function processResponse has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              private function processResponse(StatusResponse $status): StatusResult
              {
                  $code = $status->getCodRespuesta();
          
                  $result = new StatusResult();
          Severity: Minor
          Found in packages/ws/src/Api/GreSender.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                      case 'DespatchAdvice': return DocumentType::GUIA_REMISION;
          Severity: Major
          Found in packages/cpe-validator/src/Validator/Resolver/XmlTypeResolver.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        case 'VoidedDocuments': return $this->fromVoided($doc);
            Severity: Major
            Found in packages/cpe-validator/src/Validator/Resolver/XmlTypeResolver.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return '20';
              Severity: Major
              Found in packages/ws/src/Ws/Reader/XmlFilenameExtractor.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return '';
                Severity: Major
                Found in packages/ws/src/Ws/Resolver/XmlTypeResolver.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              default: return null;
                  Severity: Major
                  Found in packages/cpe-validator/src/Validator/Resolver/XmlTypeResolver.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return '';
                    Severity: Major
                    Found in packages/ws/src/Ws/Reader/XmlFilenameExtractor.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                      return Retention::class;
                      Severity: Major
                      Found in packages/ws/src/Ws/Resolver/XmlTypeResolver.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    case 'Retention': return DocumentType::RETENCION;
                        Severity: Major
                        Found in packages/cpe-validator/src/Validator/Resolver/XmlTypeResolver.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                      case 'Perception': return DocumentType::PERCEPCION;
                          Severity: Major
                          Found in packages/cpe-validator/src/Validator/Resolver/XmlTypeResolver.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                            return Summary::class;
                            Severity: Major
                            Found in packages/ws/src/Ws/Resolver/XmlTypeResolver.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                          case 40: return '9995';
                              Severity: Major
                              Found in packages/xml/src/Xml/Filter/TributoFunction.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                                return '40';
                                Severity: Major
                                Found in packages/ws/src/Ws/Reader/XmlFilenameExtractor.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                                  return $this->getFromVoidedDoc($doc);
                                  Severity: Major
                                  Found in packages/ws/src/Ws/Resolver/XmlTypeResolver.php - About 30 mins to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language