Sign upLogin

ging/social_stream

View on GitHub
Star
presence/app/assets/javascripts/presence_windowManager.js

Summary

Maintainability
F
5 days
Test Coverage

Function WINDOW has 422 lines of code (exceeds 25 allowed). Consider refactoring.
Open

PRESENCE.WINDOW = (function(P,$,undefined){

  var init = function(){ }
    
    ////////////////////
Severity: Major
Found in presence/app/assets/javascripts/presence_windowManager.js - About 2 days to fix

    Function WINDOW has a Cognitive Complexity of 104 (exceeds 5 allowed). Consider refactoring.
    Open

    PRESENCE.WINDOW = (function(P,$,undefined){

  var init = function(){ }
    
    ////////////////////
    Severity: Minor
    Found in presence/app/assets/javascripts/presence_windowManager.js - About 2 days to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File presence_windowManager.js has 424 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    ////////////////////
//WINDOW MANAGER MODULE
////////////////////

PRESENCE.WINDOW = (function(P,$,undefined){
    Severity: Minor
    Found in presence/app/assets/javascripts/presence_windowManager.js - About 6 hrs to fix

      Function createChatBox has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          var createChatBox = function(guest_slug,isGroup){
    
        var guest_name = PRESENCE.XMPPClient.getNameFromSlug(guest_slug)
        
        if(isGroup){
      Severity: Minor
      Found in presence/app/assets/javascripts/presence_windowManager.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            var toggleVideoBox = function(uiElement){
      var slug = $(uiElement.element).attr("id");
      PRESENCE.VIDEOCHAT.clickVideoChatButton(slug);
    }
        Severity: Minor
        Found in presence/app/assets/javascripts/presence_windowManager.js and 1 other location - About 45 mins to fix
        presence/app/assets/javascripts/presence_windowManager.js on lines 393..396

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            var toggleVideoBoxChange = function(uiElement){
      var slug = $(uiElement.element).attr("id");
      PRESENCE.VIDEOCHAT.clickVideoChangeChatButton(slug);
    }
        Severity: Minor
        Found in presence/app/assets/javascripts/presence_windowManager.js and 1 other location - About 45 mins to fix
        presence/app/assets/javascripts/presence_windowManager.js on lines 387..390

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            var setVideoBoxContent = function(slug,embed){
      var videoBox = getVideoBoxForSlug(slug);
      if(videoBox!=null){
        videoBox.html(embed);
      }
        Severity: Minor
        Found in presence/app/assets/javascripts/presence_windowManager.js and 1 other location - About 35 mins to fix
        presence/app/assets/javascripts/presence_windowManager.js on lines 371..376

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            var addVideoBoxContent = function(slug,embed){
      var videoBox = getVideoBoxForSlug(slug);
      if(videoBox!=null){
        videoBox.append(embed);
      }
        Severity: Minor
        Found in presence/app/assets/javascripts/presence_windowManager.js and 1 other location - About 35 mins to fix
        presence/app/assets/javascripts/presence_windowManager.js on lines 364..369

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status