Showing 102 of 115 total issues

Avoid deeply nested control flow statements.
Open

                    if len(cdup) > 0:
                        chdir(cdup)

Severity: Major
Found in git-p4.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            for line in read_pipe_lines(
                                    ["git", "diff", "%s^..%s" % (id, id), file],
                                    raw=True):
                                if regexp.search(line):
                                    if verbose:
    Severity: Major
    Found in git-p4.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                                  if self.verbose:
                                      print("Parent of %s not found. Committing into head of %s" % (branch, parent))
                                  self.commit(description, filesForCommit, branch, parent)
      Severity: Major
      Found in git-p4.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                        if (!('previous' in curCommit)) {
                            var parts = data.split(' ', 2);
                            curCommit.previous    = parts[0];
                            curCommit.file_parent = unquote(parts[1]);
                        }
        Severity: Major
        Found in gitweb/static/js/blame_incremental.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              if not m:
                                  m = re.search(r'Request too large \(over (\d+)\)', data)
          
          
          Severity: Major
          Found in git-p4.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                        if self.verbose:
                                            print("Creating temporary branch: " + tempBranch)
                                        self.commit(description, filesForCommit, tempBranch)
            Severity: Major
            Found in git-p4.py - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      for (prev, cur) in zip(self.previousDepotPaths, depotPaths):
                                          prev_list = prev.split("/")
                                          cur_list = cur.split("/")
                                          for i in range(0, min(len(cur_list), len(prev_list))):
                                              if cur_list[i] != prev_list[i]:
              Severity: Major
              Found in git-p4.py - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                            if parent == branch:
                                                parent = ""
                                            else:
                                                fullBranch = self.projectName + branch
                                                if fullBranch not in self.p4BranchesInGit:
                Severity: Major
                Found in git-p4.py - About 45 mins to fix

                  Function searchParent has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def searchParent(self, parent, branch, target):
                          targetTree = read_pipe(["git", "rev-parse",
                                                  "{}^{{tree}}".format(target)]).strip()
                          for line in read_pipe_lines(["git", "rev-list", "--format=%H %T",
                                                       "--no-merges", parent]):
                  Severity: Minor
                  Found in git-p4.py - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid deeply nested control flow statements.
                  Open

                                          if branch_arg_given:
                                              raise P4CommandException("Error: branch %s does not exist." % self.branch)
                                          else:
                                              raise P4CommandException("Error: no branch %s; perhaps specify one with --branch." %
                                                  self.branch)
                  Severity: Major
                  Found in git-p4.py - About 45 mins to fix

                    Function exceedsLargeFileThreshold has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def exceedsLargeFileThreshold(self, relPath, contents):
                            if gitConfigInt('git-p4.largeFileThreshold'):
                                contentsSize = sum(len(d) for d in contents)
                                if contentsSize > gitConfigInt('git-p4.largeFileThreshold'):
                                    return True
                    Severity: Minor
                    Found in git-p4.py - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function p4_build_cmd has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                    def p4_build_cmd(cmd):
                        """Build a suitable p4 command line.
                    
                           This consolidates building and returning a p4 command line into one
                           location. It means that hooking into the environment, or other
                    Severity: Minor
                    Found in git-p4.py - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid deeply nested control flow statements.
                    Open

                                        if originP4Change > p4Change:
                                            print("%s (%s) is newer than %s (%s). "
                                                   "Updating p4 branch from origin."
                                                   % (originHead, originP4Change,
                                                      remoteHead, p4Change))
                    Severity: Major
                    Found in git-p4.py - About 45 mins to fix

                      Function edit_template has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def edit_template(self, template_file):
                              """Invoke the editor to let the user change the submission message.
                      
                                 Return true if okay to continue with the submit.
                                 """
                      Severity: Minor
                      Found in git-p4.py - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method Client.connect has 6 return statements (exceeds 4 allowed).
                      Open

                      func (c *Client) connect() (uconn net.Conn, hconn net.Conn, addr string, err error) {
                          uconn, err = DefaultSocket.Dial()
                          if err != nil {
                              if e, ok := err.(*net.OpError); ok && (os.IsNotExist(e.Err) || e.Err == syscall.ECONNREFUSED) {
                                  if err = c.startProxy(); err == nil {
                      Severity: Major
                      Found in contrib/persistent-https/client.go - About 40 mins to fix

                        Function p4_read_pipe has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        def p4_read_pipe(c, ignore_error=False, raw=False, *k, **kw):
                        Severity: Minor
                        Found in git-p4.py - About 35 mins to fix

                          Function read_pipe has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                          def read_pipe(c, ignore_error=False, raw=False, *k, **kw):
                          Severity: Minor
                          Found in git-p4.py - About 35 mins to fix

                            Function streamTag has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                def streamTag(self, gitStream, labelName, labelDetails, commit, epoch):
                            Severity: Minor
                            Found in git-p4.py - About 35 mins to fix

                              Function commit has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  def commit(self, details, files, branch, parent="", allow_empty=False):
                              Severity: Minor
                              Found in git-p4.py - About 35 mins to fix

                                Function formatTimezoneInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                Open

                                function formatTimezoneInfo(hours, minutes, sep) {
                                    minutes = minutes || 0; // to be able to use formatTimezoneInfo(hh)
                                    sep = sep || ''; // default format is +/-ZZZZ
                                
                                    if (minutes < 0 || minutes > 59) {
                                Severity: Minor
                                Found in gitweb/static/js/lib/datetime.js - About 35 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Severity
                                Category
                                Status
                                Source
                                Language