Showing 102 of 115 total issues
Avoid deeply nested control flow statements. Open
for line in read_pipe_lines(
["git", "diff", "%s^..%s" % (id, id), file],
raw=True):
if regexp.search(line):
if verbose:
Avoid deeply nested control flow statements. Open
if self.verbose:
print("Parent of %s not found. Committing into head of %s" % (branch, parent))
self.commit(description, filesForCommit, branch, parent)
Avoid deeply nested control flow statements. Open
if (!('previous' in curCommit)) {
var parts = data.split(' ', 2);
curCommit.previous = parts[0];
curCommit.file_parent = unquote(parts[1]);
}
Function edit_template
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def edit_template(self, template_file):
"""Invoke the editor to let the user change the submission message.
Return true if okay to continue with the submit.
"""
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid deeply nested control flow statements. Open
if m:
limit = int(m.group(1))
raise P4RequestSizeException(exitCode, result, limit)
Avoid deeply nested control flow statements. Open
for (prev, cur) in zip(self.previousDepotPaths, depotPaths):
prev_list = prev.split("/")
cur_list = cur.split("/")
for i in range(0, min(len(cur_list), len(prev_list))):
if cur_list[i] != prev_list[i]:
Avoid deeply nested control flow statements. Open
if len(cdup) > 0:
chdir(cdup)
Function exceedsLargeFileThreshold
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def exceedsLargeFileThreshold(self, relPath, contents):
if gitConfigInt('git-p4.largeFileThreshold'):
contentsSize = sum(len(d) for d in contents)
if contentsSize > gitConfigInt('git-p4.largeFileThreshold'):
return True
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid deeply nested control flow statements. Open
if branch_arg_given:
raise P4CommandException("Error: branch %s does not exist." % self.branch)
else:
raise P4CommandException("Error: no branch %s; perhaps specify one with --branch." %
self.branch)
Avoid deeply nested control flow statements. Open
if self.verbose:
print("Creating temporary branch: " + tempBranch)
self.commit(description, filesForCommit, tempBranch)
Avoid deeply nested control flow statements. Open
if (fragment) {
td_sha1.appendChild(fragment);
}
Avoid deeply nested control flow statements. Open
if originP4Change > p4Change:
print("%s (%s) is newer than %s (%s). "
"Updating p4 branch from origin."
% (originHead, originP4Change,
remoteHead, p4Change))
Function searchParent
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def searchParent(self, parent, branch, target):
targetTree = read_pipe(["git", "rev-parse",
"{}^{{tree}}".format(target)]).strip()
for line in read_pipe_lines(["git", "rev-list", "--format=%H %T",
"--no-merges", parent]):
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid deeply nested control flow statements. Open
if not m:
m = re.search(r'Request too large \(over (\d+)\)', data)
Method Client.connect
has 6 return statements (exceeds 4 allowed). Open
func (c *Client) connect() (uconn net.Conn, hconn net.Conn, addr string, err error) {
uconn, err = DefaultSocket.Dial()
if err != nil {
if e, ok := err.(*net.OpError); ok && (os.IsNotExist(e.Err) || e.Err == syscall.ECONNREFUSED) {
if err = c.startProxy(); err == nil {
Function p4_read_pipe
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def p4_read_pipe(c, ignore_error=False, raw=False, *k, **kw):
Function read_pipe
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def read_pipe(c, ignore_error=False, raw=False, *k, **kw):
Function commit
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def commit(self, details, files, branch, parent="", allow_empty=False):
Function streamTag
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def streamTag(self, gitStream, labelName, labelDetails, commit, epoch):
Function fixLinks
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
function fixLinks() {
var allLinks = document.getElementsByTagName("a") || document.links;
for (var i = 0, len = allLinks.length; i < len; i++) {
var link = allLinks[i];
if (!jsExceptionsRe.test(link)) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"