github-tools/github-extended

View on GitHub
src/github-extended.js

Summary

Maintainability
F
3 days
Test Coverage

Function constructor has 160 lines of code (exceeds 25 allowed). Consider refactoring.
Open

   constructor(options) {
      super(options);

      let superGetRepo = this.getRepo;
      let request = this.request || this._request; // jscs:ignore disallowDanglingUnderscores
Severity: Major
Found in src/github-extended.js - About 6 hrs to fix

    Function getRepo has 155 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          this.getRepo = (user, repo) => {
             let repository = superGetRepo(user, repo);
             let superRemove = repository.remove;
             let superFork = repository.fork;
    
    
    Severity: Major
    Found in src/github-extended.js - About 6 hrs to fix

      Function constructor has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
      Open

         constructor(options) {
            super(options);
      
            let superGetRepo = this.getRepo;
            let request = this.request || this._request; // jscs:ignore disallowDanglingUnderscores
      Severity: Minor
      Found in src/github-extended.js - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function remove has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

               repository.remove = (branchName = 'master', path = '') => {
                  function removeFile(branchName, path) {
                     return new Promise((resolve, reject) => {
                        superRemove(branchName, path, error => {
                           if (error) {
      Severity: Major
      Found in src/github-extended.js - About 2 hrs to fix

        Function search has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                 repository.search = (string, options = {}) => {
                    const FILE = 'blob';
                    const FOLDER = 'tree';
        
                    options = Object.assign({
        Severity: Minor
        Found in src/github-extended.js - About 1 hr to fix

          Function removeFolder has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                      function removeFolder() {
                         return new Promise((resolve, reject) => {
                            repository.getRef(`heads/${branchName}`, (error, sha) => {
                               if (error) {
                                  reject(error);
          Severity: Minor
          Found in src/github-extended.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                           return new Promise((resolve, reject) => {
                              repository.getRef(`heads/${branchName}`, (error, sha) => {
                                 if (error) {
                                    reject(error);
                                 }
            Severity: Major
            Found in src/github-extended.js and 1 other location - About 1 hr to fix
            src/github-extended.js on lines 183..191

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                 return new Promise((resolve, reject) => {
                                    repository.getTree(`${sha}?recursive=true`, (error, tree) => {
                                       if (error) {
                                          reject(error);
                                       }
            Severity: Major
            Found in src/github-extended.js and 1 other location - About 1 hr to fix
            src/github-extended.js on lines 173..181

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status