gitlabhq/gitlabhq

View on GitHub

Showing 1,405 of 2,015 total issues

Function bindEvents has 171 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const bindEvents = () => {
  const $newProjectForm = $('#new_project');
  const $projectImportUrl = $('#project_import_url');
  const $projectPath = $('.tab-pane.active #project_path');
  const $useTemplateBtn = $('.template-button > input');
Severity: Major
Found in app/assets/javascripts/projects/project_new.js - About 6 hrs to fix

    File sorting_helper.rb has 445 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module SortingHelper
      def sort_options_hash
        {
          sort_value_created_date      => sort_title_created_date,
          sort_value_downvotes         => sort_title_downvotes,
    Severity: Minor
    Found in app/helpers/sorting_helper.rb - About 6 hrs to fix

      Method each_pair has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
      Open

              def each_pair
                state = :key
                key = StringIO.new
                value = StringIO.new
                hex_buffer = ""
      Severity: Minor
      Found in lib/gitlab/auth/ldap/dn.rb - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function types.SET_LINE_DISCUSSIONS_FOR_FILE has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
      Open

        [types.SET_LINE_DISCUSSIONS_FOR_FILE](state, { discussion, diffPositionByLineCode }) {
          const { latestDiff } = state;
      
          const discussionLineCode = discussion.line_code;
          const fileHash = discussion.diff_file.file_hash;
      Severity: Minor
      Found in app/assets/javascripts/diffs/store/mutations.js - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function insertMarkdownText has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
      Open

      export function insertMarkdownText({
        textArea,
        text,
        tag,
        cursorOffset,
      Severity: Minor
      Found in app/assets/javascripts/lib/utils/text_markdown.js - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File search_autocomplete.js has 419 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /* eslint-disable no-return-assign, one-var, no-var, no-unused-vars, consistent-return, object-shorthand, prefer-template, class-methods-use-this, no-lonely-if, vars-on-top */
      
      import $ from 'jquery';
      import { escape, throttle } from 'underscore';
      import { s__, __, sprintf } from '~/locale';
      Severity: Minor
      Found in app/assets/javascripts/search_autocomplete.js - About 6 hrs to fix

        Class Member has 44 methods (exceeds 20 allowed). Consider refactoring.
        Open

        class Member < ApplicationRecord
          include AfterCommitQueue
          include Sortable
          include Importable
          include Expirable
        Severity: Minor
        Found in app/models/member.rb - About 6 hrs to fix

          Class GitAccess has 43 methods (exceeds 20 allowed). Consider refactoring.
          Open

            class GitAccess
              include Gitlab::Utils::StrongMemoize
          
              UnauthorizedError = Class.new(StandardError)
              NotFoundError = Class.new(StandardError)
          Severity: Minor
          Found in lib/gitlab/git_access.rb - About 5 hrs to fix

            File projects.rb has 407 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            require_dependency 'declarative_policy'
            
            module API
              class Projects < Grape::API
                include PaginationParams
            Severity: Minor
            Found in lib/api/projects.rb - About 5 hrs to fix

              Function postComment has 143 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                postComment(e) {
                  e.preventDefault();
              
                  // Get Form metadata
                  const $submitBtn = $(e.target);
              Severity: Major
              Found in app/assets/javascripts/notes.js - About 5 hrs to fix

                Class TodoService has 42 methods (exceeds 20 allowed). Consider refactoring.
                Open

                class TodoService
                  # When create an issue we should:
                  #
                  #  * create a todo for assignee if issue is assigned
                  #  * create a todo for each mentioned user on issue
                Severity: Minor
                Found in app/services/todo_service.rb - About 5 hrs to fix

                  File notification_service.rb has 400 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  class NotificationService
                    class Async
                      attr_reader :parent
                      delegate :respond_to_missing, to: :parent
                  
                  
                  Severity: Minor
                  Found in app/services/notification_service.rb - About 5 hrs to fix

                    File issuable_finder.rb has 397 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    class IssuableFinder
                      prepend FinderWithCrossProjectAccess
                      include FinderMethods
                      include CreatedAtFilter
                      include Gitlab::Utils::StrongMemoize
                    Severity: Minor
                    Found in app/finders/issuable_finder.rb - About 5 hrs to fix

                      Class Shell has 41 methods (exceeds 20 allowed). Consider refactoring.
                      Open

                        class Shell
                          GITLAB_SHELL_ENV_VARS = %w(GIT_TERMINAL_PROMPT).freeze
                      
                          Error = Class.new(StandardError)
                      
                      
                      Severity: Minor
                      Found in lib/gitlab/shell.rb - About 5 hrs to fix

                        File create_merge_request_dropdown.js has 391 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        /* eslint-disable no-new */
                        import _ from 'underscore';
                        import axios from './lib/utils/axios_utils';
                        import Flash from './flash';
                        import DropLab from './droplab/drop_lab';
                        Severity: Minor
                        Found in app/assets/javascripts/create_merge_request_dropdown.js - About 5 hrs to fix

                          Class Namespace has 40 methods (exceeds 20 allowed). Consider refactoring.
                          Open

                          class Namespace < ApplicationRecord
                            include CacheMarkdownField
                            include Sortable
                            include Gitlab::VisibilityLevel
                            include Routable
                          Severity: Minor
                          Found in app/models/namespace.rb - About 5 hrs to fix

                            Class Service has 40 methods (exceeds 20 allowed). Consider refactoring.
                            Open

                            class Service < ApplicationRecord
                              include Sortable
                              include Importable
                              include ProjectServicesLoggable
                            
                            
                            Severity: Minor
                            Found in app/models/service.rb - About 5 hrs to fix

                              Class ProjectsController has 40 methods (exceeds 20 allowed). Consider refactoring.
                              Open

                              class ProjectsController < Projects::ApplicationController
                                include API::Helpers::RelatedResourcesHelpers
                                include IssuableCollections
                                include ExtractsPath
                                include PreviewMarkdown
                              Severity: Minor
                              Found in app/controllers/projects_controller.rb - About 5 hrs to fix

                                File application_controller.rb has 386 lines of code (exceeds 250 allowed). Consider refactoring.
                                Open

                                require 'gon'
                                require 'fogbugz'
                                
                                class ApplicationController < ActionController::Base
                                  include Gitlab::GonHelper
                                Severity: Minor
                                Found in app/controllers/application_controller.rb - About 5 hrs to fix

                                  File helpers.rb has 386 lines of code (exceeds 250 allowed). Consider refactoring.
                                  Open

                                  module API
                                    module Helpers
                                      include Gitlab::Utils
                                      include Helpers::Pagination
                                  
                                  
                                  Severity: Minor
                                  Found in lib/api/helpers.rb - About 5 hrs to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language