gitlabhq/gitlabhq

View on GitHub

Showing 1,226 of 1,717 total issues

Class Commit has 48 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Commit
      include Gitlab::EncodingHelper

      attr_accessor :raw_commit, :head

Severity: Minor
Found in lib/gitlab/git/commit.rb - About 6 hrs to fix

    Method each_pair has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
    Open

                  def each_pair
                    state = :key
                    key = StringIO.new
                    value = StringIO.new
                    hex_buffer = ""
    Severity: Minor
    Found in lib/gitlab/background_migration/normalize_ldap_extern_uids_range.rb - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method each_pair has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
    Open

            def each_pair
              state = :key
              key = StringIO.new
              value = StringIO.new
              hex_buffer = ""
    Severity: Minor
    Found in lib/gitlab/auth/ldap/dn.rb - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class IssuableFinder has 47 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class IssuableFinder
      prepend FinderWithCrossProjectAccess
      include FinderMethods
      include CreatedAtFilter
    
    
    Severity: Minor
    Found in app/finders/issuable_finder.rb - About 6 hrs to fix

      File labels_select.js has 433 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /* eslint-disable no-useless-return, func-names, no-var, no-underscore-dangle, prefer-arrow-callback, max-len, one-var, no-unused-vars, one-var-declaration-per-line, prefer-template, no-new, consistent-return, object-shorthand, comma-dangle, no-shadow, no-param-reassign, brace-style, vars-on-top, quotes, no-lonely-if, no-else-return, dot-notation, no-empty */
      /* global Issuable */
      /* global ListLabel */
      
      import $ from 'jquery';
      Severity: Minor
      Found in app/assets/javascripts/labels_select.js - About 6 hrs to fix

        File projects_helper.rb has 427 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        module ProjectsHelper
          def link_to_project(project)
            link_to [project.namespace.becomes(Namespace), project], title: h(project.name) do
              title = content_tag(:span, project.name, class: 'project-name')
        
        
        Severity: Minor
        Found in app/helpers/projects_helper.rb - About 6 hrs to fix

          File projects.rb has 419 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          require_dependency 'declarative_policy'
          
          module API
            class Projects < Grape::API
              include PaginationParams
          Severity: Minor
          Found in lib/api/projects.rb - About 6 hrs to fix

            Function GitLabDropdown has 149 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              function GitLabDropdown(el1, options) {
                var searchFields, selector, self;
                this.el = el1;
                this.options = options;
                this.updateLabel = this.updateLabel.bind(this);
            Severity: Major
            Found in app/assets/javascripts/gl_dropdown.js - About 5 hrs to fix

              Class TodoService has 43 methods (exceeds 20 allowed). Consider refactoring.
              Open

              class TodoService
                # When create an issue we should:
                #
                #  * create a todo for assignee if issue is assigned
                #  * create a todo for each mentioned user on issue
              Severity: Minor
              Found in app/services/todo_service.rb - About 5 hrs to fix

                Function postComment has 143 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  postComment(e) {
                    e.preventDefault();
                
                    // Get Form metadata
                    const $submitBtn = $(e.target);
                Severity: Major
                Found in app/assets/javascripts/notes.js - About 5 hrs to fix

                  File copy_as_gfm.js has 400 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  /* eslint-disable object-shorthand, no-unused-vars, no-use-before-define, max-len, no-restricted-syntax, guard-for-in, no-continue */
                  
                  import $ from 'jquery';
                  import _ from 'underscore';
                  import { insertText, getSelectedFragment, nodeMatchesSelector } from '~/lib/utils/common_utils';
                  Severity: Minor
                  Found in app/assets/javascripts/behaviors/markdown/copy_as_gfm.js - About 5 hrs to fix

                    Class Member has 41 methods (exceeds 20 allowed). Consider refactoring.
                    Open

                    class Member < ActiveRecord::Base
                      include AfterCommitQueue
                      include Sortable
                      include Importable
                      include Expirable
                    Severity: Minor
                    Found in app/models/member.rb - About 5 hrs to fix

                      File create_merge_request_dropdown.js has 391 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      /* eslint-disable no-new */
                      import _ from 'underscore';
                      import axios from './lib/utils/axios_utils';
                      import Flash from './flash';
                      import DropLab from './droplab/drop_lab';
                      Severity: Minor
                      Found in app/assets/javascripts/create_merge_request_dropdown.js - About 5 hrs to fix

                        Class Service has 40 methods (exceeds 20 allowed). Consider refactoring.
                        Open

                        class Service < ActiveRecord::Base
                          include Sortable
                          include Importable
                        
                          serialize :properties, JSON # rubocop:disable Cop/ActiveRecordSerialize
                        Severity: Minor
                        Found in app/models/service.rb - About 5 hrs to fix

                          Class GitAccess has 40 methods (exceeds 20 allowed). Consider refactoring.
                          Open

                            class GitAccess
                              include Gitlab::Utils::StrongMemoize
                          
                              UnauthorizedError = Class.new(StandardError)
                              NotFoundError = Class.new(StandardError)
                          Severity: Minor
                          Found in lib/gitlab/git_access.rb - About 5 hrs to fix

                            Method each_pair has 131 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                          def each_pair
                                            state = :key
                                            key = StringIO.new
                                            value = StringIO.new
                                            hex_buffer = ""
                            Severity: Major
                            Found in lib/gitlab/background_migration/normalize_ldap_extern_uids_range.rb - About 5 hrs to fix

                              Method each_pair has 131 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                      def each_pair
                                        state = :key
                                        key = StringIO.new
                                        value = StringIO.new
                                        hex_buffer = ""
                              Severity: Major
                              Found in lib/gitlab/auth/ldap/dn.rb - About 5 hrs to fix

                                File search_autocomplete.js has 383 lines of code (exceeds 250 allowed). Consider refactoring.
                                Open

                                /* eslint-disable no-return-assign, one-var, no-var, no-underscore-dangle, one-var-declaration-per-line, no-unused-vars, consistent-return, object-shorthand, prefer-template, quotes, class-methods-use-this, no-lonely-if, no-else-return, vars-on-top, max-len */
                                
                                import $ from 'jquery';
                                import axios from './lib/utils/axios_utils';
                                import DropdownUtils from './filtered_search/dropdown_utils';
                                Severity: Minor
                                Found in app/assets/javascripts/search_autocomplete.js - About 5 hrs to fix

                                  Class ProjectsController has 39 methods (exceeds 20 allowed). Consider refactoring.
                                  Open

                                  class ProjectsController < Projects::ApplicationController
                                    include IssuableCollections
                                    include ExtractsPath
                                    include PreviewMarkdown
                                    include SendFileUpload
                                  Severity: Minor
                                  Found in app/controllers/projects_controller.rb - About 5 hrs to fix

                                    Class Config has 38 methods (exceeds 20 allowed). Consider refactoring.
                                    Open

                                          class Config
                                            NET_LDAP_ENCRYPTION_METHOD = {
                                              simple_tls: :simple_tls,
                                              start_tls:  :start_tls,
                                              plain:      nil
                                    Severity: Minor
                                    Found in lib/gitlab/auth/ldap/config.rb - About 5 hrs to fix
                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language