gkozlenko/node-video-lib

View on GitHub
lib/flv/amf-parser.js

Summary

Maintainability
C
1 day
Test Coverage
D
63%

Function _readByType has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    _readByType(type) {
        switch (type) {
            case TYPE_NUMBER: {
                return this._readDouble();
            }
Severity: Minor
Found in lib/flv/amf-parser.js - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

                    return this._readReference();
    Severity: Major
    Found in lib/flv/amf-parser.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return this._readLongString();
      Severity: Major
      Found in lib/flv/amf-parser.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return null;
        Severity: Major
        Found in lib/flv/amf-parser.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return undefined;
          Severity: Major
          Found in lib/flv/amf-parser.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return null;
            Severity: Major
            Found in lib/flv/amf-parser.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                              return this._readEcmaArray();
              Severity: Major
              Found in lib/flv/amf-parser.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                return this._readXmlDocument();
                Severity: Major
                Found in lib/flv/amf-parser.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                  return this._readStrictArray();
                  Severity: Major
                  Found in lib/flv/amf-parser.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                    return this._readDate();
                    Severity: Major
                    Found in lib/flv/amf-parser.js - About 30 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          _readLongString() {
                              let size = this.buffer.readUInt32BE(this.pos);
                              this.pos += 4;
                              let value = this.buffer.toString('utf8', this.pos, this.pos + size);
                              this.pos += size;
                      Severity: Major
                      Found in lib/flv/amf-parser.js and 1 other location - About 2 hrs to fix
                      lib/flv/amf-parser.js on lines 95..101

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 89.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          _readString() {
                              let size = this.buffer.readUInt16BE(this.pos);
                              this.pos += 2;
                              let value = this.buffer.toString('utf8', this.pos, this.pos + size);
                              this.pos += size;
                      Severity: Major
                      Found in lib/flv/amf-parser.js and 1 other location - About 2 hrs to fix
                      lib/flv/amf-parser.js on lines 143..149

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 89.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status