Sign upLogin

glittershark/reactable

View on GitHub
Star

Showing 30 of 183 total issues

Function getColumns has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    static getColumns(component) {
        // Can't use React.Children.map since that doesn't return a proper array
        let columns = [];
        React.Children.forEach(component.props.children, th => {
            var column = {};
Severity: Minor
Found in src/reactable/thead.jsx - About 1 hr to fix

    Function render has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        render() {
        var children = toArray(React.Children.children(this.props.children));

        if (
            this.props.data &&
    Severity: Minor
    Found in src/reactable/tr.jsx - About 1 hr to fix

      Function Numeric has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          Numeric(a, b) {
        var valA = parseFloat(a.toString().replace(/,/g,''));
        var valB = parseFloat(b.toString().replace(/,/g,''));

        // Sort non-numeric values alphabetically at the bottom of the list
      Severity: Minor
      Found in src/reactable/sort.jsx - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                              if (extractDataFrom(data, filterColumn).toString().toLowerCase().indexOf(filter) > -1) {
                            matchedChildren.push(children[i]);
                            break;
                        }
      Severity: Major
      Found in src/reactable/table.jsx - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if (this._filterable[filterColumn](extractDataFrom(data, filterColumn).toString(), filter)) {
                            matchedChildren.push(children[i]);
                            break;
                        }
        Severity: Major
        Found in src/reactable/table.jsx - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                      if (
                                columns.find(function(element) {
                                return element.key === column.key;
                            }) === undefined
                            ) {
          Severity: Major
          Found in src/reactable/table.jsx - About 45 mins to fix

            Function extractDataFrom has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            export function extractDataFrom(key, column) {
    var value;
    if (
        typeof(key) !== 'undefined' &&
            key !== null &&
            Severity: Minor
            Found in src/reactable/lib/extract_data_from.jsx - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this function.
            Open

                                return this._sortable[currentSort.column](keyB, keyA);
            Severity: Major
            Found in src/reactable/table.jsx - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return 0;
              Severity: Major
              Found in src/reactable/sort.jsx - About 30 mins to fix

                Function onSort has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    onSort(column) {
        // Don't perform sort on unsortable columns
        if (typeof(this._sortable[column]) === 'undefined') {
            return;
        }
                Severity: Minor
                Found in src/reactable/table.jsx - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language