Sign upLogin

gocodebox/lifterlms

View on GitHub
Star
assets/js/builder/Controllers/Sync.js

Summary

Maintainability
C
1 day
Test Coverage

File Sync.js has 318 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Sync builder data to the server
 *
 * @since 3.16.0
 * @version 4.17.0
Severity: Minor
Found in assets/js/builder/Controllers/Sync.js - About 3 hrs to fix

    Function process_object_updates has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            function process_object_updates( data, type, parent, main_data ) {

            if ( ! data[ type ] ) {
                return data;
            }
    Severity: Minor
    Found in assets/js/builder/Controllers/Sync.js - About 1 hr to fix

      Function do_ajax_save has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              function do_ajax_save() {

            // prevent simultaneous saves
            if ( self.saving ) {
                return;
      Severity: Minor
      Found in assets/js/builder/Controllers/Sync.js - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                                if ( info.id != info.orig_id ) {
                            model.set( 'id', info.id );
                            delete model._unsavedChanges.id;
                        }
        Severity: Minor
        Found in assets/js/builder/Controllers/Sync.js and 1 other location - About 45 mins to fix
        assets/js/builder/Controllers/Sync.js on lines 429..432

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                            if ( info.id != info.orig_id ) {
                        model.set( 'id', info.id );
                        delete model._unsavedChanges.id;
                    }
        Severity: Minor
        Found in assets/js/builder/Controllers/Sync.js and 1 other location - About 45 mins to fix
        assets/js/builder/Controllers/Sync.js on lines 459..462

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status