Sign upLogin

gocodebox/lifterlms

View on GitHub
Star
assets/js/builder/Views/Assignment.js

Summary

Maintainability
C
1 day
Test Coverage

Function add_existing_assignment_click has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

            add_existing_assignment_click: function( event ) {

                event.preventDefault();

                if ( this.is_addon_available() ) {
Severity: Minor
Found in assets/js/builder/Views/Assignment.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                        this.post_search_popover = new Popover( {
                        el: '#llms-existing-assignment',
                        args: {
                            backdrop: true,
                            closeable: true,
    Severity: Major
    Found in assets/js/builder/Views/Assignment.js and 1 other location - About 5 hrs to fix
    assets/js/builder/Views/Quiz.js on lines 317..335

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 142.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                    if ( 'clone' === event.action ) {

                    assignment = _.prepareAssignmentObjectForCloning( assignment );

                } else {
    Severity: Major
    Found in assets/js/builder/Views/Assignment.js and 2 other locations - About 1 hr to fix
    assets/js/builder/Views/QuestionType.js on lines 142..148
    assets/js/builder/Views/Quiz.js on lines 285..295

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                on_trashed: function( assignment ) {

                this.lesson.set( 'assignment_enabled', 'no' );
                this.lesson.set( 'assignment', '' );
    Severity: Major
    Found in assets/js/builder/Views/Assignment.js and 1 other location - About 1 hr to fix
    assets/js/builder/Views/Quiz.js on lines 365..374

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status