Sign upLogin

goodeggs/tap-dayforce

View on GitHub
Star

Showing 2 of 6 total issues

Function _transform_records has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    def _transform_records(self, start, end, counter):
        for _, record in self.client.get_employees(
            filterUpdatedStartDate=singer.utils.strftime(start), filterUpdatedEndDate=singer.utils.strftime(end)
        ).yield_records():
            if record:
Severity: Minor
Found in tap_dayforce/streams.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function whitelist_sensitive_info has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def whitelist_sensitive_info(self, data: Dict) -> Dict:
        for collection in WHITELISTED_COLLECTIONS:
            if data.get(collection, {}).get("Items") is not None:
                items = []
                for i, item in enumerate(data.get(collection, {}).get("Items")):
Severity: Minor
Found in tap_dayforce/streams.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language