Sign upLogin

google/chromeos-filesystems

View on GitHub
Star
shared_tests/onWriteFileRequested.js

Summary

Maintainability
D
2 days
Test Coverage

Function exports has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(onWriteFileRequested, onReadFileRequested,
  onOpenFileRequested) {
    describe('onWriteFileRequested', function() {
      it('should write the correct data to a new file', function(done) {
        var id = 987;
Severity: Major
Found in shared_tests/onWriteFileRequested.js - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          it('should write the correct data to a new file', function(done) {
        var id = 987;

        var openOptions = {
          filePath: '/new_write.txt',
    Severity: Major
    Found in shared_tests/onWriteFileRequested.js and 1 other location - About 1 day to fix
    shared_tests/onWriteFileRequested.js on lines 54..91

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 207.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        it('should overwrite the correct data to an exisiting file', function(done) {
      var id = 1024;

      var openOptions = {
        filePath: '/3.txt',
    Severity: Major
    Found in shared_tests/onWriteFileRequested.js and 1 other location - About 1 day to fix
    shared_tests/onWriteFileRequested.js on lines 14..51

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 207.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status