gopheracademy/gcon

File responsive.js has 1066 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/*
Plugin Name: amCharts Responsive
Description: This plugin add responsive functionality to JavaScript Charts and Maps.
Author: Martynas Majeris, amCharts
Contributors: Ohad Schneider

Function applyConfig has 58 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  var applyConfig = function( current, override ) {
    if ( isNullOrUndefined( override ) ) {
      return;
    }

Function checkRules has 35 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  var checkRules = function() {

    var width = chart.divRealWidth;
    var height = chart.divRealHeight;

Avoid deeply nested control flow statements.

Open

            if ( isNullOrUndefined( overrideValue[ k ] ) || isNullOrUndefined( overrideValue[ k ].id ) ) {
              idPresentOnAllOverrideElements = false;
              break;
            }

Avoid deeply nested control flow statements.

Open

            for ( var i = 0; i < overrideValue.length; i++ ) {
              var correspondingCurrentElement = findArrayObjectById( currentValue, overrideValue[ i ].id );
              if ( correspondingCurrentElement === undefined ) {
                throw ( 'could not find element to override in "' + property + '" with ID: ' + overrideValue[ i ].id );
              }

Avoid deeply nested control flow statements.

Open

            for ( var l = 0; l < overrideValue.length; l++ ) {
              applyConfig( currentValue[ l ], overrideValue[ l ] );
            }

TODO found

Open

    // TODO - re-apply zooms/slices as necessary

• Exclude checks
  • Disable engine
  • Disable check

Identical blocks of code found in 3 locations. Consider refactoring.

Open

AmCharts.addInitHandler( function( chart ) {
  "use strict";

  if ( chart.responsive === undefined || chart.responsive.ready === true || chart.responsive.enabled !== true )
    return;

• Read up
  Read up