gopheracademy/gcon

View on GitHub
assets/admin/global/plugins/highstock/js/highcharts-3d.src.js

Summary

Maintainability
F
3 mos
Test Coverage

File highcharts-3d.src.js has 1146 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// ==ClosureCompiler==
// @compilation_level SIMPLE_OPTIMIZATIONS

/**
 * @license Highcharts JS v4.1.9 (2015-10-07)
Severity: Major
Found in assets/admin/global/plugins/highstock/js/highcharts-3d.src.js - About 2 days to fix

    Function arc3d has 109 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Highcharts.SVGRenderer.prototype.arc3d = function (shapeArgs) {
    
        shapeArgs.alpha *= deg2rad;
        shapeArgs.beta *= deg2rad;
        var result = this.g(),
    Severity: Major
    Found in assets/admin/global/plugins/highstock/js/highcharts-3d.src.js - About 4 hrs to fix

      Function arc3dPath has 98 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Highcharts.SVGRenderer.prototype.arc3dPath = function (shapeArgs) {
          var cx = shapeArgs.x, // x coordinate of the center
              cy = shapeArgs.y, // y coordinate of the center
              start = shapeArgs.start, // start angle
              end = shapeArgs.end - 0.00001, // end angle
      Severity: Major
      Found in assets/admin/global/plugins/highstock/js/highcharts-3d.src.js - About 3 hrs to fix

        Function cuboid has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        Highcharts.SVGRenderer.prototype.cuboid = function (shapeArgs) {
        
            var result = this.g(),
            paths = this.cuboidPath(shapeArgs);
        
        Severity: Major
        Found in assets/admin/global/plugins/highstock/js/highcharts-3d.src.js - About 2 hrs to fix

          Function perspective has 52 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function perspective(points, chart, insidePlotArea) {
              var options3d = chart.options.chart.options3d,
                  inverted = false,
                  origin;
          
          Severity: Major
          Found in assets/admin/global/plugins/highstock/js/highcharts-3d.src.js - About 2 hrs to fix

            Function animate has 45 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                result.animate = function (args, duration, complete) {
                    if (defined(args.end) || defined(args.start)) {
                        this._shapeArgs = this.shapeArgs;
            
                        Highcharts.SVGElement.prototype.animate.call(this, {
            Severity: Minor
            Found in assets/admin/global/plugins/highstock/js/highcharts-3d.src.js - About 1 hr to fix

              Function cuboidPath has 40 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              Highcharts.SVGRenderer.prototype.cuboidPath = function (shapeArgs) {
                  var x = shapeArgs.x,
                      y = shapeArgs.y,
                      z = shapeArgs.z,
                      h = shapeArgs.height,
              Severity: Minor
              Found in assets/admin/global/plugins/highstock/js/highcharts-3d.src.js - About 1 hr to fix

                Consider simplifying this complex logical expression.
                Open

                    if (this.is3d()) {
                        var inverted = this.inverted,
                            clipBox = this.clipBox,
                            margin = this.margin,
                            x = inverted ? 'y' : 'x',
                Severity: Major
                Found in assets/admin/global/plugins/highstock/js/highcharts-3d.src.js - About 1 hr to fix

                  Function curveTo has 8 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  function curveTo(cx, cy, rx, ry, start, end, dx, dy) {
                  Severity: Major
                  Found in assets/admin/global/plugins/highstock/js/highcharts-3d.src.js - About 1 hr to fix

                    Avoid deeply nested control flow statements.
                    Open

                                            if (point.graphic) {
                                                point.graphic.animate(point.shapeArgs, series.options.animation);                    
                                            }
                    Severity: Major
                    Found in assets/admin/global/plugins/highstock/js/highcharts-3d.src.js - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                              if (!reversed) {
                                                  if (point.stackY) {
                                                      point.shapeArgs.y = point.plotY + yAxis.translate(point.stackY);
                                                  } else {
                                                      point.shapeArgs.y = point.plotY + (point.negative ? -point.height : point.height);
                      Severity: Major
                      Found in assets/admin/global/plugins/highstock/js/highcharts-3d.src.js - About 45 mins to fix

                        Consider simplifying this complex logical expression.
                        Open

                            if (args[0].chart.options3d && args[0].chart.options3d.enabled) {
                                // Normalize alpha and beta to (-360, 360) range
                                args[0].chart.options3d.alpha = (args[0].chart.options3d.alpha || 0) % 360;
                                args[0].chart.options3d.beta = (args[0].chart.options3d.beta || 0) % 360;
                        
                        Severity: Major
                        Found in assets/admin/global/plugins/highstock/js/highcharts-3d.src.js - About 40 mins to fix

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                          (function (Highcharts) {
                              /**
                              Shorthands for often used function
                          */ 
                          /**
                          assets/admin/global/plugins/highcharts/js/highcharts-3d.src.js on lines 15..1570

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 16363.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status