File data.src.js
has 629 lines of code (exceeds 250 allowed). Consider refactoring. Open
/**
* @license Highstock JS v2.1.9 (2015-10-07)
* Data module
*
* (c) 2012-2014 Torstein Honsi
Function complete
has 96 lines of code (exceeds 25 allowed). Consider refactoring. Open
complete: function () {
var columns = this.columns,
xColumns = [],
type,
Function parseColumn
has 78 lines of code (exceeds 25 allowed). Consider refactoring. Open
parseColumn: function (column, col) {
var rawColumns = this.rawColumns,
columns = this.columns,
row = column.length,
val,
Function getColumnDistribution
has 55 lines of code (exceeds 25 allowed). Consider refactoring. Open
getColumnDistribution: function () {
var chartOptions = this.chartOptions,
options = this.options,
xColumns = [],
getValueCount = function (type) {
Function parseGoogleSpreadsheet
has 48 lines of code (exceeds 25 allowed). Consider refactoring. Open
parseGoogleSpreadsheet: function () {
var self = this,
options = this.options,
googleSpreadsheetKey = options.googleSpreadsheetKey,
columns = this.columns,
Function parseCSV
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
parseCSV: function () {
var self = this,
options = this.options,
csv = options.csv,
columns = this.columns,
Function parseDate
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
parseDate: function (val) {
var parseDate = this.options.parseDate,
ret,
key,
format,
Function success
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
success: function (json) {
// Prepare the data from the spreadsheat
var cells = json.feed.entry,
cell,
cellCount = cells.length,
Avoid deeply nested control flow statements. Open
if (diff !== descending && descending !== undefined) {
if (this.alternativeFormat) {
this.dateFormat = this.alternativeFormat;
row = column.length;
this.alternativeFormat = this.dateFormats[this.dateFormat].alternative;
Avoid deeply nested control flow statements. Open
if (builder.readers[r].configName === 'x') {
builder.readers[r].configName = 'name';
}
TODO found Open
for (j = 0; j < columns[0].length; j++) { // TODO: which column's length should we use here
- Exclude checks
Similar blocks of code found in 3 locations. Consider refactoring. Open
(function (Highcharts) {
// Utilities
var each = Highcharts.each,
pick = Highcharts.pick,
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 6745.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76