Sign upLogin

gosddc/vagrant-vcloudair

View on GitHub
Star

Showing 29 of 109 total issues

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        def reboot_vm(vm_id)
          params = {
            'method'  => :post,
            'command' => "/vApp/vm-#{vm_id}/power/action/reboot"
          }
Severity: Major
Found in lib/vagrant-vcloudair/driver/version_5_1.rb and 7 other locations - About 20 mins to fix
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 488..496
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 504..512
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 519..527
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 532..540
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 626..634
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 639..647
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 1127..1135

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        def reset_vapp(vapp_id)
          params = {
            'method'  => :post,
            'command' => "/vApp/vapp-#{vapp_id}/power/action/reset"
          }
Severity: Major
Found in lib/vagrant-vcloudair/driver/version_5_1.rb and 7 other locations - About 20 mins to fix
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 488..496
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 504..512
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 532..540
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 611..619
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 626..634
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 639..647
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 1127..1135

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        def reboot_vapp(vapp_id)
          params = {
            'method'  => :post,
            'command' => "/vApp/vapp-#{vapp_id}/power/action/reboot"
          }
Severity: Major
Found in lib/vagrant-vcloudair/driver/version_5_1.rb and 7 other locations - About 20 mins to fix
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 488..496
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 519..527
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 532..540
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 611..619
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 626..634
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 639..647
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 1127..1135

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        def reset_vm(vm_id)
          params = {
            'method'  => :post,
            'command' => "/vApp/vm-#{vm_id}/power/action/reset"
          }
Severity: Major
Found in lib/vagrant-vcloudair/driver/version_5_1.rb and 7 other locations - About 20 mins to fix
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 488..496
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 504..512
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 519..527
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 532..540
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 611..619
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 639..647
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 1127..1135

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        def poweron_vm(vm_id)
          params = {
            'method'  => :post,
            'command' => "/vApp/vm-#{vm_id}/power/action/powerOn"
          }
Severity: Major
Found in lib/vagrant-vcloudair/driver/version_5_1.rb and 7 other locations - About 20 mins to fix
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 488..496
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 504..512
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 519..527
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 532..540
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 611..619
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 626..634
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 1127..1135

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        def redeploy_edge_gateway(edge_gateway_id)
          params = {
            'method'  => :post,
            'command' => "/admin/edgeGateway/#{edge_gateway_id}/action/redeploy"
          }
Severity: Major
Found in lib/vagrant-vcloudair/driver/version_5_1.rb and 7 other locations - About 20 mins to fix
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 488..496
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 504..512
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 519..527
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 532..540
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 611..619
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 626..634
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 639..647

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        def poweron_vapp(vapp_id)
          params = {
            'method'  => :post,
            'command' => "/vApp/vapp-#{vapp_id}/power/action/powerOn"
          }
Severity: Major
Found in lib/vagrant-vcloudair/driver/version_5_1.rb and 7 other locations - About 20 mins to fix
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 488..496
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 504..512
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 519..527
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 611..619
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 626..634
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 639..647
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 1127..1135

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        def delete_vapp(vapp_id)
          params = {
            'method'  => :delete,
            'command' => "/vApp/vapp-#{vapp_id}"
          }
Severity: Minor
Found in lib/vagrant-vcloudair/driver/version_5_1.rb and 1 other location - About 20 mins to fix
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 547..555

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        def delete_vm(vm_id)
          params = {
            'method'  => :delete,
            'command' => "/vApp/vm-#{vm_id}"
          }
Severity: Minor
Found in lib/vagrant-vcloudair/driver/version_5_1.rb and 1 other location - About 20 mins to fix
lib/vagrant-vcloudair/driver/version_5_1.rb on lines 452..460

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language